Repository navigation
Recover knowledge activation with verified owner-merge reconciliation - #324
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The knowledge service blocks snapshot activation after owner-merged onboarding and administration PRs because those commits were not produced by its automated proposal ledger. Add an explicit, signed reconciliation command that verifies the exact merged history before admitting it.
The operator prepares a plan for the full current main SHA, inspects it, and applies it after a second verification. Admission requires an allowlisted authenticated operator and merger, matching PR merge/head commits, passing named checks on each exact head, both knowledge validators, and a fully verified snapshot. Immutable receipts are rechecked by audit, activation, status, and publisher control; future unknown commits still block activation. Automatic proposal gates, disposal records, pauses, and publication modes retain their existing behavior.
Validation: all 17 focused recovery tests pass, independent implementation review is clear, and real read-only evidence passes for all 15 historical merges and the complete snapshot. The full local provider suite completed: 3,855 passed, 18 skipped, and four failures from the unsupported system dependency described below. Documentation links, citations, and strict SPEC freshness checks also pass. Four tests hit an incompatible system MCP 2 installation; all 166 tests in the affected files pass in an isolated environment with the declared MCP 1 dependency. Exact-head historical CI reruns pass.
Final revision CI: both push and PR suites pass on
86e6ab5afd42324477dc652516ebe06e2f41a91d, including complete unit, CLI, packaged runtime, documentation, SPEC, and knowledge checks.