Repository navigation
Clarify string fields in knowledge intake draft responses - #325
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generators can return
new_page: falsefor an unused optional field, which strict intake validation rejects and can stall an event batch. Clarify that required operation fields and all six optional content fields are strings; unused optional fields should be omitted or set to"", andnew_pagedenotes a destination path.Native intake and the default
kb-intake.draftdriver both usedraft_changes, so the shared prompt covers both paths. The existing schema still enforces the field types. Update the service SPEC to record this contract.Validation: 135 passed, 1 skipped across the existing intake, model dispatch, improvement adapter, autonomous objective, and evolution tests in the declared dependency environment. Documentation links, citations, strict SPEC freshness, and
git diff --checkpass.