Repository navigation
fix(kb): bootstrap containment authority with private permissions - #329
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh containment authority could fail its first scheduler tick: importing consumer updates created the authority parent through a child directory, so a
002umask left the parent group-writable and policy signing rejected it. Initialize and validate the authority itself before taking the consumer-import lock, releasing the authority lock before ACK handling can reacquire it. Existing insecure directories are rejected without changing their permissions.Validation: all four new regressions fail on the previous main and pass with this fix. All 79 focused bootstrap, containment, and maintenance-flow tests pass, including real ledger leases, signed empty policies,
002/022umasks, and unchanged rejection of existing0775/0777directories. No SDK, knowledge resource, consumer protocol, or bot pin changes.