Repository navigation
fix(zcode): preserve completed results through slow native journals - #339
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly knowledge drafting could lose a completed GLM answer: ZCode writes stream events without awaiting pipe backpressure and forces exit after a short grace period. Slow durable event recording left stdout truncated mid-JSON, so the service correctly rejected the missing result even though the model had finished.
Capture stdout and stderr into private, per-invocation anonymous regular files and tail them with independent offsets. Preserve live durable journaling, drain all completed output before validation, and enforce the producer deadline with a cancelable watchdog. Cleanup still reaps the owned process group. Result, exit-code, model, tool-containment and publication checks remain in force; no ZCode global settings change.
Validation: 56 focused tests passed, including a forced-exit producer with a slow durable sink, exact result retention, real timeout while the sink is slow, completed-producer drain beyond the deadline, malformed/missing results, interruption cleanup, temporary-file permissions and existing provider/native-journal tests. Documentation checks and strict SPEC freshness pass. No models were invoked for regression tests. Full CI must pass before native rollout.