Repository navigation
Conversation
khadijja1
approved these changes
Sep 8, 2026
khadijja1
requested changes
Sep 8, 2026
khadijja1
left a comment
Collaborator
There was a problem hiding this comment.
remove the pycache folder to maintain a clean repository and avoid conflict. Use Git's .gitignore
khadijja1
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores the actual, tested implementations of preprocessor.py, ocr.py, and parsers/cnic.py. PR #9 (an automated Copilot fix for the CI failure) replaced these with minimal stub versions to make imports resolve, silently discarding weeks of tested logic: rotation correction, calibrated blur threshold, deskew, and most CNIC field extraction (name, father_name, all three dates, and address were entirely removed, leaving only cnic_number and a naive gender match).
Which module(s) does it touch?
docling_pk/preprocessor.py, docling_pk/ocr.py, docling_pk/parsers/cnic.py. Also removes docling_pk/parsers/pycache (compiled bytecode, should never be committed) and tests/test_placeholder.py (superseded by the real test files already in the repo).
How did you test it?
This is the exact code from feat/preprocessor and feat/ocr, both already tested extensively against real CNIC and certificate photos throughout the project, documented in the design doc's Technical Approach section.
Checklist: