Repository navigation
Test Coverage Improvements (>95%) & CI Coverage Fix - #9
Merged
Khubaib8281 merged 3 commits intoJul 30, 2026
Merged
Conversation
Khubaib8281
self-requested a review
July 30, 2026 08:36
Khubaib8281
approved these changes
Jul 30, 2026
Khubaib8281
left a comment
Member
There was a problem hiding this comment.
Great addition. The implementation is clear, and the accompanying tests provide good confidence. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed?
Fixed 0% Coverage Reporting in CI Workflow (
.github/workflows/ci.yml):pip install -e .(editable mode) and setPYTHONPATH=..coverage.pywas checking local files while tests executed against installedsite-packages, resulting in an artificial 0% report. Coverage reporting in CI now correctly tracks the source files.Added New Unit Tests (
tests/):tests/test_provider_methods.py: Added coverage for allFakerPKProvidermethods when generating multiple outputs (count > 1) and added error handling assertions for invalid inputs (e.g.pytest.raises(ValueError)for invalid industry names).tests/test_student_profile_gender_cnic_alignment.py: Verified CNIC gender digit alignment (odd for male, even for female).tests/test_student_profile_multiple_count.py: Validated list generation structure for student profiles.Results
@Khubaib8281 Kindly Review this PR whenever you have time.