Repository navigation
Feat/final release - #13
Merged
Merged
Conversation
…README, and add Lead Engineer lab note
Maazkorejo
approved these changes
Sep 5, 2026
Khubaib8281
requested changes
Sep 6, 2026
Khubaib8281
left a comment
Member
There was a problem hiding this comment.
tests/test_performance.py
- Could we mark this as a separate performance/integration test? A hard 2s threshold may be flaky across different CI runners.
tests/test_factual_grounding.py
- Could we avoid downloading the model during the regular test suite? Perhaps mark these as integration tests and run them in an environment where the model is pre-cached.
tests/test_cli.py
- The test name says this verifies repeated
--criteria, but only one criterion is passed here. Could we pass it twice and assert both are included in the output?
tests/test_evaluator.py
- Minor: since
CRITERIA_REGISTRYis global, could we use a fixture to restore its state after these tests? This would make the tests less sensitive to execution order.
README.md
- Since omitting
criteriaruns all registered criteria, could we mention that adding future criteria may also increase the evaluation cost/latency?
MahrukhBaig
force-pushed
the
feat/final-release
branch
from
September 6, 2026 19:49
52611ec to
57a4cb6
Compare
Khubaib8281
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[One sentence: what does this PR add, fix, or change?]
Which module(s) does it touch?
[List the files changed and why each was changed]
How did you test it?
[What tests cover this? Run: pytest <test_file> and paste the result summary]
Edge cases handled:
[What inputs could break this? How did you handle them?]
Checklist: