Repository navigation
Fix @ai answers failing with "name 'chan_name' is not defined" - #11
Merged
Merged
Conversation
Splitting the asker line into PM and channel variants dropped the line that sets chan_name, so every @ai question (channel and PM) failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since bb518fc ("support @ai via PM") every
@aiquestion fails; the server log shows:When the asker line in
AIChat.answer()was split into a PM and a channel variant, the line that setschan_namewas removed, but both variants still use it.Fix
Restore
chan_name = context.get("channel_name") or f"channel {context.get('channel')}".Testing
pyflakes ai_chat.py: no undefined names left.answer()with a stubbed Workers AI call: channel question, PM question and a context withoutchannel_nameall return the answer with the right "Penanya: ..." line.🤖 Generated with Claude Code