Repository navigation
Protect shared accounts (murid, tamu, ...) and tell their users apart - #4
Merged
Merged
Conversation
The server's accounts are shared: all students log in as "murid", guests as
"tamu", invitees as "hadirin", the student council as "osis".
- /du: anyone on a shared account could delete it for everyone ("murid" +
"/du murid" + "y" counted as deleting your own account). Accounts in the
new SHARED_ACCOUNTS setting cannot be deleted via the bot, not even by
admins or with --force; admins can still remove them in the TeamTalk client
- Join/login spam detection keyed people by username + IP, so every student
on "murid" behind the school network counted as one person. For shared
accounts the key is now username/nickname + IP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…OSIS - A channel created by "murid" belonged to every student on that account, so any of them could delete it or give it away. Non-admin shared accounts now cannot /rc, /dc or /to via the bot; admin accounts keep their rights - pemateri and f.osis (shared admin accounts) join the default SHARED_ACCOUNTS, so they cannot be deleted via the bot and are told apart by nickname in spam detection Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On this server many people share one account: all students log in as
murid, guests astamu, invitees ashadirin, the student council asosis.muridsends/du murid, theny: the bot treats it as "deleting your own account", and no student can log in any more. Same fortamu,hadirin,osis.muridbehind the school network shared one counter again.What
SHARED_ACCOUNTS(defaulttamu,murid,hadirin,osis,pemateri,f.osis,guest; case-insensitive).--force. Admins can still remove them in the TeamTalk client if they really mean to.muridare counted separately; someone hopping channels is still caught. Without a nickname it falls back to the username.muridbelonged to every student on it, so any of them could delete it or give it away. Non-admin shared accounts can no longer/rc,/dcor/tovia the bot. Admin accounts (pemateri,F.OSIS) keep their admin rights./help du,/help rc, README, docs and CHANGELOG updated.pemateriandF.OSISare shared admin accounts, so they are in the default list: they cannot be deleted via the bot and are told apart by nickname, but keep all admin rights.Tested
With the real TeamTalk DLL: person keys for shared/personal accounts; 7 students on
muridfrom one IP logging in and joining → no warnings; one student hopping → caught undermurid/<nickname>;/du murid,/du murid --force, and admins deletingtamu/hadirin/osis/Muridrefused; deleting your own personal account still asks for confirmation; students onmuridcannot create, delete or transfer channels; admins onpemateristill can; personal accounts unchanged;pemateri/F.OSISnot deletable. All earlier suites pass.Independent of #2/#3; this one is a security fix, so it is worth merging first.
🤖 Generated with Claude Code