Repository navigation
feat: Add new logout strings from core - #695
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All replaced resources exist in Core with matching localized formatting, and no obsolete references remain.
Pull request overview
Centralizes logout labels and confirmation text in the shared Core resources.
Changes:
- Uses Core resources for the logout item and dialog.
- Removes duplicated logout translations across all supported locales.
File summaries
| File | Description |
|---|---|
MyAccountScreen.kt |
Uses shared Core logout strings. |
values/strings.xml |
Removes duplicate English strings. |
values-da/strings.xml |
Removes duplicate Danish strings. |
values-de/strings.xml |
Removes duplicate German strings. |
values-el/strings.xml |
Removes duplicate Greek strings. |
values-es/strings.xml |
Removes duplicate Spanish strings. |
values-fi/strings.xml |
Removes duplicate Finnish strings. |
values-fr/strings.xml |
Removes duplicate French strings. |
values-it/strings.xml |
Removes duplicate Italian strings. |
values-nb/strings.xml |
Removes duplicate Norwegian strings. |
values-nl/strings.xml |
Removes duplicate Dutch strings. |
values-pl/strings.xml |
Removes duplicate Polish strings. |
values-pt/strings.xml |
Removes duplicate Portuguese strings. |
values-sv/strings.xml |
Removes duplicate Swedish strings. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
solrubado
force-pushed
the
update-logout-strings
branch
from
September 3, 2026 14:03
6bdc143 to
3e491f0
Compare
LunarX
approved these changes
Sep 3, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.