Repository navigation
fix(linux/gui): menus open on Wayland - #270
Merged
Merged
Conversation
The window now runs as the user, so on a Wayland desktop it is a native Wayland window. Opening a menu moves the keyboard focus to the menu's popup, and the handler that closed menus when the window lost focus (written for the old root window on X11, where a menu grab could outlive a switch to another program) cancelled every menu the moment it opened. The handler is now connected on X11 only.
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window now runs as the user, so on a Wayland desktop it is a native Wayland window. Opening a menu moves the keyboard focus to the menu's popup, and the handler that closed menus when the window lost focus (written for the old root window on X11, where a menu grab could outlive a switch to another program) cancelled every menu the moment it opened. The handler is now connected on X11 only.
Linked issue
Fixes #
What does this pull request do?
Tests
Anything else? (optional)
By opening this pull request I confirm that it targets
dev, that I commented on the linked issue before starting, and that I ran the tests listed above.