Skip to content

feat: add a net11.0 target - #48

Merged
DecSmith42 merged 3 commits into
mainfrom
feature/cld-net11-target
Nov 11, 2026
Merged

DecSmith42 merged 3 commits into
mainfrom
feature/cld-net11-target

Conversation

@DecSmith42

@DecSmith42 DecSmith42 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Dec · project thread

Before: The Invex.FileSystem package was built only for .NET 10, and CI ran the tests only on net10.0. PushToNuget also worked out the package version again on its own, so it could look for package files that don't exist and fail.

After: The package ships both a net10.0 and a net11.0 build. The Validate and Build workflows run the test matrix on both frameworks, and the README, getting-started page and AGENTS.md list both. PushToNuget now pushes the packages for the version SetupBuildInfo worked out.

How: Invex.FileSystem and Invex.FileSystem.Tests now use <TargetFrameworks>net10.0;net11.0</TargetFrameworks>. The build uses Invex.Atom 5.2.0: _atom/_atom.csproj references Invex.Atom.Module.GitHubWorkflows and Invex.Atom.Module.GitVersion 5.2.0, which is on NuGet and supersedes the never-published 5.1.0. In _atom/IBuild.cs, TestFrameworkNames gains WorkflowLabels.Dotnet.Framework.Net_11_0, and BuildOptions.Steps.SetupDotnet.Dotnet110X() installs the .NET 11 SDK. Regenerating the workflows after the move gave no diff.

The push fix: PushToNuget now also consumes SetupBuildInfo's BuildVersion, so Build.yml passes build-version to that job. PushProject picks packages by BuildVersion. A release run checks out the tag detached, and that checkout can work out a different version. The Atom v5.1.0 release failed in exactly this way, with "Sequence contains no matching element" in PushProject.

The workflows were regenerated with Gen. DocFX still builds the API docs from the net10.0 output, since both builds have the same API. Locally the Release build has 0 warnings, and 95/95 tests pass on each framework.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1

Invex.FileSystem and its tests now target net10.0;net11.0, the Validate
and Build workflows run the test matrix on both frameworks, and the docs
list both target frameworks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 01:50
Copilot AI previously approved these changes Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues remain for the update adding .NET 11 support alongside .NET 10.

No open issues 🎉

What changed in this PR

Adds .NET 11 support to Invex.FileSystem while retaining .NET 10 compatibility, with matching test coverage in the CI matrices and updated documentation.

Changes:

  • Multi-targets the library and test projects for net10.0 and net11.0.
  • Adds net11.0 to Atom’s test framework list and both generated workflow matrices.
  • Updates package and contributor documentation to list both supported frameworks.
File Description
tests/​Invex.FileSystem.Tests/​Invex.FileSystem.Tests.csproj Targets tests at both frameworks.
src/​Invex.FileSystem/​Invex.FileSystem.csproj Builds the library for both frameworks.
README.md Lists .NET 10 and .NET 11 support.
docs/​getting-started.md Updates supported framework information.
AGENTS.md Updates project targets and SDK guidance.
.github/​workflows/​Validate.yml Adds .NET 11 to the validation test matrix.
.github/​workflows/​Build.yml Adds .NET 11 to the build test matrix.
_atom/​IBuild.cs Adds net11.0 to the workflow generation source.

Review effort: Balanced

PushToNuget now consumes SetupBuildInfo's BuildVersion as well as its
BuildId. PushProject picks packages by BuildVersion, and a release run's
detached tag checkout can recompute a different one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 01:53
Copilot AI previously approved these changes Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues were identified for the .NET 11 support and package-publishing updates.

No open issues 🎉

Review effort: Balanced

Uses Atom's Dotnet110X step and Net_11_0 framework label in place of the interim literals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 05:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are reported for the .NET 11 support and publishing-version changes.

No open issues 🎉

Review effort: Balanced

@DecSmith42
DecSmith42 merged commit 145fbc9 into main Nov 11, 2026
25 checks passed
@DecSmith42
DecSmith42 deleted the feature/cld-net11-target branch November 11, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants