Repository navigation
feat: add a net11.0 target - #48
Merged
Merged
Conversation
Invex.FileSystem and its tests now target net10.0;net11.0, the Validate and Build workflows run the test matrix on both frameworks, and the docs list both target frameworks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
There was a problem hiding this comment.
🟢 Approved
No active review issues remain for the update adding .NET 11 support alongside .NET 10.
No open issues 🎉
What changed in this PR
Adds .NET 11 support to Invex.FileSystem while retaining .NET 10 compatibility, with matching test coverage in the CI matrices and updated documentation.
Changes:
- Multi-targets the library and test projects for
net10.0andnet11.0. - Adds
net11.0to Atom’s test framework list and both generated workflow matrices. - Updates package and contributor documentation to list both supported frameworks.
| File | Description |
|---|---|
tests/Invex.FileSystem.Tests/Invex.FileSystem.Tests.csproj |
Targets tests at both frameworks. |
src/Invex.FileSystem/Invex.FileSystem.csproj |
Builds the library for both frameworks. |
README.md |
Lists .NET 10 and .NET 11 support. |
docs/getting-started.md |
Updates supported framework information. |
AGENTS.md |
Updates project targets and SDK guidance. |
.github/workflows/Validate.yml |
Adds .NET 11 to the validation test matrix. |
.github/workflows/Build.yml |
Adds .NET 11 to the build test matrix. |
_atom/IBuild.cs |
Adds net11.0 to the workflow generation source. |
Review effort: Balanced
PushToNuget now consumes SetupBuildInfo's BuildVersion as well as its BuildId. PushProject picks packages by BuildVersion, and a release run's detached tag checkout can recompute a different one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Uses Atom's Dotnet110X step and Net_11_0 framework label in place of the interim literals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Dec · project thread
Before: The Invex.FileSystem package was built only for .NET 10, and CI ran the tests only on net10.0. PushToNuget also worked out the package version again on its own, so it could look for package files that don't exist and fail.
After: The package ships both a net10.0 and a net11.0 build. The Validate and Build workflows run the test matrix on both frameworks, and the README, getting-started page and AGENTS.md list both. PushToNuget now pushes the packages for the version SetupBuildInfo worked out.
How:
Invex.FileSystemandInvex.FileSystem.Testsnow use<TargetFrameworks>net10.0;net11.0</TargetFrameworks>. The build uses Invex.Atom 5.2.0:_atom/_atom.csprojreferencesInvex.Atom.Module.GitHubWorkflowsandInvex.Atom.Module.GitVersion5.2.0, which is on NuGet and supersedes the never-published 5.1.0. In_atom/IBuild.cs,TestFrameworkNamesgainsWorkflowLabels.Dotnet.Framework.Net_11_0, andBuildOptions.Steps.SetupDotnet.Dotnet110X()installs the .NET 11 SDK. Regenerating the workflows after the move gave no diff.The push fix:
PushToNugetnow also consumesSetupBuildInfo'sBuildVersion, so Build.yml passesbuild-versionto that job.PushProjectpicks packages byBuildVersion. A release run checks out the tag detached, and that checkout can work out a different version. The Atom v5.1.0 release failed in exactly this way, with "Sequence contains no matching element" in PushProject.The workflows were regenerated with
Gen. DocFX still builds the API docs from the net10.0 output, since both builds have the same API. Locally the Release build has 0 warnings, and 95/95 tests pass on each framework.🤖 Generated with Claude Code
https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1