Repository navigation
Target net11.0 and build with the .NET 11 SDK - #41
Merged
Merged
Conversation
On net11.0, ProcessRunner reads stdout and stderr as one ordered stream of lines with Process.ReadAllLines/ReadAllLinesAsync instead of the OutputDataReceived/ErrorDataReceived events, and a process killed by a POSIX signal is reported by signal name in the ProcessException message. The net10.0 build keeps the event-based reader. The public API is the same on both targets. CI tests both frameworks. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Pins SDK 11.0.100-rc.2.26504.105 in global.json (prereleases allowed, latest-feature roll-forward), sets LangVersion 15, and adds a CI step that installs the RC2 SDK next to the .NET 10 SDK, which still provides the runtime for net10.0 tests. Target frameworks are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Pins SDK 11.0.100 in global.json (stable only, latest-major roll-forward, matching main) and installs 11.0.x in CI instead of the release candidate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The reader replacement lacks mixed-stream integration coverage, and synchronous signal handling remains untested, leaving output suppression, stream classification, and sync/async parity unverified.
3 open issues
What changed in this PR
Adds .NET 11 support to Invex.Process while retaining the .NET 10 target and existing public API.
Changes:
- Multi-targets the library and tests, using the .NET 11 SDK and C# 15.
- Adds .NET 11 output readers and signal-aware failure messages while preserving the .NET 10 event-based reader.
- Expands CI testing to both frameworks and updates tests and documentation.
| File | Description |
|---|---|
tests/Invex.Process.Tests/ProcessRunnerTests.cs |
Adds an asynchronous signal-termination test. |
tests/Invex.Process.Tests/Invex.Process.Tests.csproj |
Targets both .NET 10 and .NET 11. |
src/Invex.Process/ProcessRunner.cs |
Adds framework-specific readers and signal diagnostics. |
src/Invex.Process/Invex.Process.csproj |
Packages both framework targets. |
src/Invex.Process/_usings.cs |
Imports POSIX signal types. |
README.md |
Lists both supported targets. |
global.json |
Sets the SDK version to 11.0.100. |
docs/getting-started.md |
Describes .NET 11 support and behavior. |
Directory.Build.props |
Selects C# 15. |
AGENTS.md |
Updates build and language guidance. |
.github/workflows/Validate.yml |
Installs both SDKs and tests both targets. |
.github/workflows/Dependabot Enable auto-merge.yml |
Adds .NET 11 SDK setup. |
.github/workflows/Cleanup Prereleases.yml |
Adds .NET 11 SDK setup. |
.github/workflows/Build.yml |
Installs both SDKs and expands the test matrix. |
_atom/IBuild.cs |
Defines the additional SDK setup and test target. |
Review effort: Balanced
actions/setup-dotnet ignores the version when rollForward is latestMajor and installs the LTS SDK (10.0.x), which can't satisfy 11.0.100. That broke GitHub's NuGet dependency submission scan. latestMinor makes it install 11.x. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Adds Run and RunAsync tests that write to both streams with per-stream transforms, a suppressed line on each, and an unterminated final line, and checks the captured text and the log level each line is logged at. Covers the signal path through Run as well as RunAsync. Also corrects the docs: on .NET 11 lines arrive in the order they become available, not strictly write order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The .NET 11 output reader’s cancellation and stream-disposal changes need runtime validation, including on Windows, because existing tests assert only the exception, not that the child remains running.
No open issues 🎉
3 resolved since last review
Review effort: Balanced
The net10.0 tests and the Atom build project need the .NET 10 runtime, which the .NET 11 SDK doesn't include. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Requested by Dec · project thread
Before: the package targets
net10.0only and is built with the .NET 10 SDK and C# 14.ProcessRunnercollects output through theOutputDataReceived/ErrorDataReceivedevents. A process killed by a signal is reported only by its exit code.After: the package targets
net10.0andnet11.0, and the repo builds with the .NET 11 SDK (11.0.100) and C# 15. Onnet11.0,ProcessRunneruses the newProcess.ReadAllLines/ReadAllLinesAsyncAPIs to read stdout and stderr as one interleaved stream of lines. Lines are handled in the order they become available, with stderr first when both streams are ready. A process killed by a POSIX signal fails with "terminated by signal SIGTERM (exit code …)". The public API is identical on both targets, and thenet10.0build keeps the event-based reader.How:
#if NET11_0_OR_GREATERinProcessRunner, with both readers sharing one line handler.global.jsonpins 11.0.100 and rolls forward within 11.x (latestMinor), andLangVersionis 15. It isn'tlatestMajorbecauseactions/setup-dotnetthen installs the LTS SDK, which breaks GitHub's NuGet dependency submission. CI installs the 11.0.x SDK alongside 10.0.x (which still provides the runtime fornet10.0tests), and the test matrix now covers both frameworks. New tests cover mixed stdout and stderr with per-stream transforms throughRunandRunAsyncon both targets, plus signal termination through both onnet11.0. The docs mention the new target.Generated by Claude Code