Skip to content

Build with .NET 11 and target net11.0 - #41

Merged
DecSmith42 merged 6 commits into
mainfrom
claude/project-thread-h7vtsx
Nov 11, 2026
Merged

DecSmith42 merged 6 commits into
mainfrom
claude/project-thread-h7vtsx

Conversation

@DecSmith42

@DecSmith42 DecSmith42 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Dec · project thread

Before: the repo builds with the .NET 10 SDK (global.json 10.0.403) and C# 14. Invex.Rez and Invex.Rez.Configuration target net10.0 and netstandard2.0, and the tests target net10.0 and net48.

After: the repo builds with the .NET 11 SDK (11.0.100) and C# 15. Both libraries also target net11.0 (net10.0;net11.0;netstandard2.0), so each package ships a net11.0 build. The tests also target net11.0 (net10.0;net11.0;net48), and CI runs them on it.

How: global.json pins 11.0.100, rolls forward within 11.x (latestMinor) and excludes prereleases. It isn't latestMajor because actions/setup-dotnet then ignores the version and installs the LTS SDK (10.0.x), which breaks GitHub's NuGet dependency submission. LangVersion is 15. CI adds an 11.0.x setup-dotnet step after the existing 10.0.x one, which still provides the runtime for net10.0 tests. The TestProjects matrix adds net11.0 next to net10.0 on Ubuntu and Windows, and the net48 job is unchanged. The build uses Atom 5.2.0: _atom/_atom.csproj references Invex.Atom.Module.GitHubWorkflows and Invex.Atom.Module.GitVersion 5.2.0, which is on NuGet and supersedes the never-published 5.1.0. The 11.0.x step is BuildOptions.Steps.SetupDotnet.Dotnet110X(), the matrix uses WorkflowLabels.Dotnet.Framework.Net_11_0, and regenerating the workflows after the move gave no diff. PushToNuget now also consumes BuildVersion from SetupBuildInfo, because PushProject picks packages by BuildVersion and a release run's detached tag checkout can recompute a different one. Workflows are regenerated with atom Gen, and README, AGENTS.md and the docs list the new target framework.


Generated by Claude Code

Pins SDK 11.0.100-rc.2.26504.105 in global.json (prereleases allowed,
latest-feature roll-forward), sets LangVersion 15, and adds a CI step that
installs the RC2 SDK next to the .NET 10 SDK, which still provides the
runtime for net10.0 tests. Target frameworks are unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Pins SDK 11.0.100 in global.json (stable only, latest-major roll-forward,
matching main) and installs 11.0.x in CI instead of the release candidate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 00:08
@DecSmith42 DecSmith42 self-assigned this Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The prerequisites omit the .NET 10 runtime needed by the tests and Atom build tool, so README.md and AGENTS.md need clarification for clean-machine setup.

1 open issue
What changed in this PR

This PR moves Invex.Rez’s build toolchain to the .NET 11 SDK and C# 15 while leaving target frameworks and published packages unchanged.

Changes:

  • Select SDK 11.0.100 and C# 15.
  • Add .NET 11 setup to generated workflows while retaining .NET 10 for runtime compatibility.
  • Update contributor documentation to name the new SDK.
File Description
README.md Updates the documented development SDK requirement.
global.json Selects SDK 11.0.100 with existing roll-forward settings.
Directory.Build.props Sets C# language version to 15.
AGENTS.md Updates SDK and language-version guidance.
.github/​workflows/​Validate.yml Adds .NET 11 setup to validation jobs.
.github/​workflows/​Dependabot Enable auto-merge.yml Adds .NET 11 setup for Dependabot automation.
.github/​workflows/​Cleanup Prereleases.yml Adds .NET 11 setup for prerelease cleanup.
.github/​workflows/​Build.yml Adds .NET 11 setup to build and publishing jobs.
_atom/​IBuild.cs Configures shared .NET 11 setup while retaining .NET 10.

Review effort: Balanced

Comment thread README.md Resolved
actions/setup-dotnet ignores the version when rollForward is latestMajor and
installs the LTS SDK (10.0.x), which can't satisfy 11.0.100. That broke
GitHub's NuGet dependency submission scan. latestMinor makes it install 11.x.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 00:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The SDK roll-forward setting blocks newer-major SDKs despite the stated policy, and contributor prerequisites omit the .NET 10 runtime required to run tests and Atom.

2 open issues
1 previously missed issue

In code that hasn't changed since last review

Low severity Document the .NET 10 runtime prerequisite

AGENTS.md:25

These prerequisites no longer cover running the tests or Atom: both projects still target net10.0, while the .NET 11 SDK only supplies its own major-version runtime. Document the .NET 10 runtime requirement here too so contributors following this guide can execute the listed commands without a missing-framework error.

Review effort: Balanced

Comment thread global.json Resolved
The net10.0 tests and the Atom build project need the .NET 10 runtime, which
the .NET 11 SDK doesn't include.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 00:24
Copilot AI previously approved these changes Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are reported for the .NET 11 and C# 15 build-toolchain update.

1 open issue
1 resolved since last review

Review effort: Balanced

@DecSmith42
DecSmith42 marked this pull request as ready for review November 11, 2026 00:29
Invex.Rez and Invex.Rez.Configuration now target net10.0, net11.0 and
netstandard2.0, and the tests target net10.0, net11.0 and net48. CI runs the
test matrix on net11.0 as well.

PushToNuget now consumes BuildVersion from SetupBuildInfo: PushProject picks
packages by BuildVersion, and a release run's detached tag checkout can
recompute a different one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 01:56
@DecSmith42 DecSmith42 changed the title Build with the .NET 11 SDK and C# 15 Build with .NET 11 and target net11.0 Nov 11, 2026
Copilot AI previously approved these changes Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues were identified for the .NET 11 and C# 15 toolchain update.

1 open issue

Review effort: Balanced

Uses Atom's Dotnet110X step and Net_11_0 framework label in place of the interim literals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 05:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR description inaccurately documents the build requirements, omitting the Atom 5.2.0 upgrade and the Dotnet110X()/Net_11_0 helper APIs.

2 open issues

Review effort: Balanced

Comment thread _atom/_atom.csproj Resolved
@DecSmith42
DecSmith42 merged commit 1b2fa7a into main Nov 11, 2026
18 checks passed
@DecSmith42
DecSmith42 deleted the claude/project-thread-h7vtsx branch November 11, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants