You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before: the repo builds with the .NET 10 SDK (global.json 10.0.403) and C# 14. Invex.Rez and Invex.Rez.Configuration target net10.0 and netstandard2.0, and the tests target net10.0 and net48.
After: the repo builds with the .NET 11 SDK (11.0.100) and C# 15. Both libraries also target net11.0 (net10.0;net11.0;netstandard2.0), so each package ships a net11.0 build. The tests also target net11.0 (net10.0;net11.0;net48), and CI runs them on it.
How: global.json pins 11.0.100, rolls forward within 11.x (latestMinor) and excludes prereleases. It isn't latestMajor because actions/setup-dotnet then ignores the version and installs the LTS SDK (10.0.x), which breaks GitHub's NuGet dependency submission. LangVersion is 15. CI adds an 11.0.x setup-dotnet step after the existing 10.0.x one, which still provides the runtime for net10.0 tests. The TestProjects matrix adds net11.0 next to net10.0 on Ubuntu and Windows, and the net48 job is unchanged. The build uses Atom 5.2.0: _atom/_atom.csproj references Invex.Atom.Module.GitHubWorkflows and Invex.Atom.Module.GitVersion 5.2.0, which is on NuGet and supersedes the never-published 5.1.0. The 11.0.x step is BuildOptions.Steps.SetupDotnet.Dotnet110X(), the matrix uses WorkflowLabels.Dotnet.Framework.Net_11_0, and regenerating the workflows after the move gave no diff. PushToNuget now also consumes BuildVersion from SetupBuildInfo, because PushProject picks packages by BuildVersion and a release run's detached tag checkout can recompute a different one. Workflows are regenerated with atom Gen, and README, AGENTS.md and the docs list the new target framework.
Pins SDK 11.0.100-rc.2.26504.105 in global.json (prereleases allowed,
latest-feature roll-forward), sets LangVersion 15, and adds a CI step that
installs the RC2 SDK next to the .NET 10 SDK, which still provides the
runtime for net10.0 tests. Target frameworks are unchanged.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Pins SDK 11.0.100 in global.json (stable only, latest-major roll-forward,
matching main) and installs 11.0.x in CI instead of the release candidate.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The prerequisites omit the .NET 10 runtime needed by the tests and Atom build tool, so README.md and AGENTS.md need clarification for clean-machine setup.
actions/setup-dotnet ignores the version when rollForward is latestMajor and
installs the LTS SDK (10.0.x), which can't satisfy 11.0.100. That broke
GitHub's NuGet dependency submission scan. latestMinor makes it install 11.x.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The SDK roll-forward setting blocks newer-major SDKs despite the stated policy, and contributor prerequisites omit the .NET 10 runtime required to run tests and Atom.
These prerequisites no longer cover running the tests or Atom: both projects still target net10.0, while the .NET 11 SDK only supplies its own major-version runtime. Document the .NET 10 runtime requirement here too so contributors following this guide can execute the listed commands without a missing-framework error.
The net10.0 tests and the Atom build project need the .NET 10 runtime, which
the .NET 11 SDK doesn't include.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Invex.Rez and Invex.Rez.Configuration now target net10.0, net11.0 and
netstandard2.0, and the tests target net10.0, net11.0 and net48. CI runs the
test matrix on net11.0 as well.
PushToNuget now consumes BuildVersion from SetupBuildInfo: PushProject picks
packages by BuildVersion, and a release run's detached tag checkout can
recompute a different one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Dec · project thread
Before: the repo builds with the .NET 10 SDK (
global.json10.0.403) and C# 14.Invex.RezandInvex.Rez.Configurationtargetnet10.0andnetstandard2.0, and the tests targetnet10.0andnet48.After: the repo builds with the .NET 11 SDK (11.0.100) and C# 15. Both libraries also target
net11.0(net10.0;net11.0;netstandard2.0), so each package ships anet11.0build. The tests also targetnet11.0(net10.0;net11.0;net48), and CI runs them on it.How:
global.jsonpins 11.0.100, rolls forward within 11.x (latestMinor) and excludes prereleases. It isn'tlatestMajorbecauseactions/setup-dotnetthen ignores the version and installs the LTS SDK (10.0.x), which breaks GitHub's NuGet dependency submission.LangVersionis 15. CI adds an 11.0.x setup-dotnet step after the existing 10.0.x one, which still provides the runtime fornet10.0tests. TheTestProjectsmatrix addsnet11.0next tonet10.0on Ubuntu and Windows, and thenet48job is unchanged. The build uses Atom 5.2.0:_atom/_atom.csprojreferencesInvex.Atom.Module.GitHubWorkflowsandInvex.Atom.Module.GitVersion5.2.0, which is on NuGet and supersedes the never-published 5.1.0. The 11.0.x step isBuildOptions.Steps.SetupDotnet.Dotnet110X(), the matrix usesWorkflowLabels.Dotnet.Framework.Net_11_0, and regenerating the workflows after the move gave no diff.PushToNugetnow also consumesBuildVersionfromSetupBuildInfo, becausePushProjectpicks packages byBuildVersionand a release run's detached tag checkout can recompute a different one. Workflows are regenerated withatom Gen, and README, AGENTS.md and the docs list the new target framework.Generated by Claude Code