Skip to content

feat: add a net11.0 target - #46

Merged
DecSmith42 merged 4 commits into
mainfrom
feature/cld-net11-target
Nov 11, 2026
Merged

DecSmith42 merged 4 commits into
mainfrom
feature/cld-net11-target

Conversation

@DecSmith42

@DecSmith42 DecSmith42 commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Dec · project thread

Before: The Invex.StructuredText, Invex.StructuredText.GithubActions and Invex.StructuredText.AzureDevopsPipelines packages were built only for .NET 10, and CI ran the tests only on net10.0. PushToNuget also worked out the package version again on its own, so it could look for package files that don't exist and fail.

After: All three packages ship both a net10.0 and a net11.0 build. The Validate and Build workflows run the test matrix on both frameworks, and the README, docs and AGENTS.md list both. PushToNuget now pushes the packages for the version SetupBuildInfo worked out.

How: The three libraries, the three test projects and the samples project (which Invex.StructuredText.GithubActions.Tests references) now use <TargetFrameworks>net10.0;net11.0</TargetFrameworks>. The netstandard2.0 source generator is unchanged. The build uses Invex.Atom 5.2.0: _atom/_atom.csproj references Invex.Atom.Module.GitHubWorkflows and Invex.Atom.Module.GitVersion 5.2.0, which is on NuGet and supersedes the never-published 5.1.0. In _atom/IBuild.cs, TestFrameworkNames gains WorkflowLabels.Dotnet.Framework.Net_11_0, and BuildOptions.Steps.SetupDotnet.Dotnet110X() installs the .NET 11 SDK. Regenerating the workflows after the move gave no diff.

The push fix: PushToNuget now also consumes SetupBuildInfo's BuildVersion, so Build.yml passes build-version to that job. PushProject picks packages by BuildVersion. A release run checks out the tag detached, and that checkout can work out a different version. The Atom v5.1.0 release failed in exactly this way, with "Sequence contains no matching element" in PushProject.

The workflows were regenerated with Gen. DocFX still builds the API docs from the net10.0 output. Locally the Release build has 0 warnings, and on each framework the tests pass: core 24/24, GithubActions 227/227, AzureDevopsPipelines 177/177.


Generated by Claude Code

The three Invex.StructuredText packages, their test projects and the
samples project now target net10.0;net11.0. The Validate and Build
workflows run the test matrix on both frameworks, and the docs list both
target frameworks. The netstandard2.0 source generator is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
PushToNuget now consumes SetupBuildInfo's BuildVersion as well as its
BuildId. PushProject picks packages by BuildVersion, and a release run's
detached tag checkout can recompute a different one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 01:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The sample’s documented run commands omit the explicit --framework required by its multiple target frameworks, leaving those instructions unusable.

1 open issue
What changed in this PR

Adds .NET 11 support alongside .NET 10 across the libraries, tests, and samples, and aligns NuGet publishing with the version computed during build setup.

Changes:

  • Multi-targets all three libraries, their test projects, and the samples executable.
  • Expands CI testing to both frameworks and passes BuildVersion to NuGet publishing.
  • Updates documentation and contributor guidance to reflect framework support.
File Description
tests/​Invex.StructuredText.Tests/​Invex.StructuredText.Tests.csproj Tests core functionality on both frameworks.
tests/​Invex.StructuredText.GithubActions.Tests/​Invex.StructuredText.GithubActions.Tests.csproj Tests GitHub Actions support on both frameworks.
tests/​Invex.StructuredText.AzureDevopsPipelines.Tests/​Invex.StructuredText.AzureDevopsPipelines.Tests.csproj Tests Azure DevOps support on both frameworks.
src/​Invex.StructuredText/​Invex.StructuredText.csproj Adds the .NET 11 core library target.
src/​Invex.StructuredText.GithubActions/​Invex.StructuredText.GithubActions.csproj Adds the .NET 11 GitHub Actions target.
src/​Invex.StructuredText.AzureDevopsPipelines/​Invex.StructuredText.AzureDevopsPipelines.csproj Adds the .NET 11 Azure DevOps target.
samples/​Invex.StructuredText.Samples/​Invex.StructuredText.Samples.csproj Multi-targets the samples executable.
README.md Documents both supported targets.
docs/​getting-started.md Updates framework requirements.
docs/​faq.md Lists both supported frameworks.
docs/​architecture.md Updates the framework overview.
AGENTS.md Updates contributor guidance for dual targeting.
.github/​workflows/​Validate.yml Adds .NET 11 to validation tests.
.github/​workflows/​Build.yml Expands tests and forwards the publishing version.
_atom/​IBuild.cs Defines dual-framework testing and publishing version consumption.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 11, 2026 01:58
Copilot AI previously approved these changes Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are recorded for the dual-framework support and NuGet publishing-version changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Uses Atom's Dotnet110X step and Net_11_0 framework label in place of the interim literals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 05:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues remain for the .NET 11 support and NuGet publishing updates.

No open issues 🎉

Review effort: Balanced

@DecSmith42
DecSmith42 merged commit 86a77be into main Nov 11, 2026
25 checks passed
@DecSmith42
DecSmith42 deleted the feature/cld-net11-target branch November 11, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants