Repository navigation
feat: add a net11.0 target - #46
Merged
Merged
Conversation
The three Invex.StructuredText packages, their test projects and the samples project now target net10.0;net11.0. The Validate and Build workflows run the test matrix on both frameworks, and the docs list both target frameworks. The netstandard2.0 source generator is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
PushToNuget now consumes SetupBuildInfo's BuildVersion as well as its BuildId. PushProject picks packages by BuildVersion, and a release run's detached tag checkout can recompute a different one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
There was a problem hiding this comment.
🟡 Changes recommended
The sample’s documented run commands omit the explicit --framework required by its multiple target frameworks, leaving those instructions unusable.
1 open issue
What changed in this PR
Adds .NET 11 support alongside .NET 10 across the libraries, tests, and samples, and aligns NuGet publishing with the version computed during build setup.
Changes:
- Multi-targets all three libraries, their test projects, and the samples executable.
- Expands CI testing to both frameworks and passes
BuildVersionto NuGet publishing. - Updates documentation and contributor guidance to reflect framework support.
| File | Description |
|---|---|
| tests/Invex.StructuredText.Tests/Invex.StructuredText.Tests.csproj | Tests core functionality on both frameworks. |
| tests/Invex.StructuredText.GithubActions.Tests/Invex.StructuredText.GithubActions.Tests.csproj | Tests GitHub Actions support on both frameworks. |
| tests/Invex.StructuredText.AzureDevopsPipelines.Tests/Invex.StructuredText.AzureDevopsPipelines.Tests.csproj | Tests Azure DevOps support on both frameworks. |
| src/Invex.StructuredText/Invex.StructuredText.csproj | Adds the .NET 11 core library target. |
| src/Invex.StructuredText.GithubActions/Invex.StructuredText.GithubActions.csproj | Adds the .NET 11 GitHub Actions target. |
| src/Invex.StructuredText.AzureDevopsPipelines/Invex.StructuredText.AzureDevopsPipelines.csproj | Adds the .NET 11 Azure DevOps target. |
| samples/Invex.StructuredText.Samples/Invex.StructuredText.Samples.csproj | Multi-targets the samples executable. |
| README.md | Documents both supported targets. |
| docs/getting-started.md | Updates framework requirements. |
| docs/faq.md | Lists both supported frameworks. |
| docs/architecture.md | Updates the framework overview. |
| AGENTS.md | Updates contributor guidance for dual targeting. |
| .github/workflows/Validate.yml | Adds .NET 11 to validation tests. |
| .github/workflows/Build.yml | Expands tests and forwards the publishing version. |
| _atom/IBuild.cs | Defines dual-framework testing and publishing version consumption. |
Review effort: Balanced
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Uses Atom's Dotnet110X step and Net_11_0 framework label in place of the interim literals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requested by Dec · project thread
Before: The Invex.StructuredText, Invex.StructuredText.GithubActions and Invex.StructuredText.AzureDevopsPipelines packages were built only for .NET 10, and CI ran the tests only on net10.0. PushToNuget also worked out the package version again on its own, so it could look for package files that don't exist and fail.
After: All three packages ship both a net10.0 and a net11.0 build. The Validate and Build workflows run the test matrix on both frameworks, and the README, docs and AGENTS.md list both. PushToNuget now pushes the packages for the version SetupBuildInfo worked out.
How: The three libraries, the three test projects and the samples project (which
Invex.StructuredText.GithubActions.Testsreferences) now use<TargetFrameworks>net10.0;net11.0</TargetFrameworks>. The netstandard2.0 source generator is unchanged. The build uses Invex.Atom 5.2.0:_atom/_atom.csprojreferencesInvex.Atom.Module.GitHubWorkflowsandInvex.Atom.Module.GitVersion5.2.0, which is on NuGet and supersedes the never-published 5.1.0. In_atom/IBuild.cs,TestFrameworkNamesgainsWorkflowLabels.Dotnet.Framework.Net_11_0, andBuildOptions.Steps.SetupDotnet.Dotnet110X()installs the .NET 11 SDK. Regenerating the workflows after the move gave no diff.The push fix:
PushToNugetnow also consumesSetupBuildInfo'sBuildVersion, so Build.yml passesbuild-versionto that job.PushProjectpicks packages byBuildVersion. A release run checks out the tag detached, and that checkout can work out a different version. The Atom v5.1.0 release failed in exactly this way, with "Sequence contains no matching element" in PushProject.The workflows were regenerated with
Gen. DocFX still builds the API docs from the net10.0 output. Locally the Release build has 0 warnings, and on each framework the tests pass: core 24/24, GithubActions 227/227, AzureDevopsPipelines 177/177.Generated by Claude Code