Repository navigation
Build with .NET 11 and test on net11.0 - #34
Merged
Merged
Conversation
Pins SDK 11.0.100-rc.2.26504.105 in global.json (prereleases allowed, latest-feature roll-forward), sets LangVersion 15, and adds a CI step that installs the RC2 SDK next to the .NET 10 SDK, which still provides the runtime for net10.0 tests. Target frameworks are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Pins SDK 11.0.100 in global.json (stable only, latest-major roll-forward, matching main) and installs 11.0.x in CI instead of the release candidate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The README omits the .NET 10 runtime prerequisite, so users installing only the documented .NET 11 SDK cannot launch the Atom commands.
1 open issue
What changed in this PR
Updates the repository’s build tooling to the .NET 11 SDK and C# 15 while leaving target frameworks and published packages unchanged.
Changes:
- Pins SDK 11.0.100 and sets the language version to C# 15.
- Adds .NET 11 setup to Atom-generated workflows while retaining .NET 10 for runtime compatibility.
- Updates the README’s contributor SDK prerequisite.
| File | Description |
|---|---|
| README.md | Names .NET 11 as the required development SDK. |
| global.json | Selects SDK 11.0.100 with existing roll-forward settings. |
| Directory.Build.props | Sets C# language version to 15. |
| .github/workflows/Validate.yml | Adds .NET 11 setup to validation jobs. |
| .github/workflows/Dependabot Enable auto-merge.yml | Adds .NET 11 setup for Dependabot automation. |
| .github/workflows/Cleanup Prereleases.yml | Adds .NET 11 setup for prerelease cleanup. |
| .github/workflows/Build.yml | Adds .NET 11 setup to build, release, and documentation jobs. |
| _atom/IBuild.cs | Defines the shared .NET 11 setup step alongside .NET 10. |
Review effort: Balanced
actions/setup-dotnet ignores the version when rollForward is latestMajor and installs the LTS SDK (10.0.x), which can't satisfy 11.0.100. That broke GitHub's NuGet dependency submission scan. latestMinor makes it install 11.x. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
The net10.0 tests and the Atom build project need the .NET 10 runtime, which the .NET 11 SDK doesn't include. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
DecSmith42
marked this pull request as ready for review
November 11, 2026 00:29
The ArtifactClean tests now target net10.0 and net11.0, and CI runs TestProjects as a net10.0/net11.0 matrix (it previously ran net10.0 only). The tool itself stays on net10.0: its RID-specific Native AOT packages put files under tools/any/<rid> with no framework folder, so a second target framework collides when packing (NU5118). Atom's own tool does the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Uses Atom's Dotnet110X step and Net_11_0 framework label in place of the interim literals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Requested by Dec · project thread
Before: the repo builds with the .NET 10 SDK (
global.json10.0.403) and C# 14. The tool and its tests targetnet10.0, and CI runs the tests onnet10.0only.After: the repo builds with the .NET 11 SDK (11.0.100) and C# 15. The tests target
net10.0andnet11.0, and CI runs them as anet10.0/net11.0matrix. Theartcleantool package stays onnet10.0.How:
global.jsonpins 11.0.100, rolls forward within 11.x (latestMinor) and excludes prereleases. It isn'tlatestMajorbecauseactions/setup-dotnetthen ignores the version and installs the LTS SDK (10.0.x), which breaks GitHub's NuGet dependency submission.LangVersionis 15. CI adds an 11.0.x setup-dotnet step after the existing 10.0.x one, which still provides the runtime fornet10.0tests.TestProjectsgets a test-framework matrix. The tool stays single-target because its RID-specific Native AOT packages put files undertools/any/<rid>with no framework folder, so a second target framework failsdotnet packwith NU5118. Invex.Atom.Tool does the same. The build uses Atom 5.2.0:_atom/_atom.csprojreferencesInvex.Atom.Module.GitHubWorkflowsandInvex.Atom.Module.GitVersion5.2.0, which is on NuGet and supersedes the never-published 5.1.0. The 11.0.x step isBuildOptions.Steps.SetupDotnet.Dotnet110X(), the matrix usesWorkflowLabels.Dotnet.Framework.Net_11_0, and regenerating the workflows after the move gave no diff. TheBuildVersionfix going into the other repos isn't needed here: thisPushToNugetpushes every staged.nupkgand doesn't pick by version. Workflows are regenerated withatom Gen, and the README and AGENTS.md describe the targets.Generated by Claude Code