Skip to content

Build with .NET 11 and test on net11.0 - #34

Merged
DecSmith42 merged 6 commits into
mainfrom
claude/project-thread-h7vtsx
Nov 11, 2026
Merged

DecSmith42 merged 6 commits into
mainfrom
claude/project-thread-h7vtsx

Conversation

@DecSmith42

@DecSmith42 DecSmith42 commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Dec · project thread

Before: the repo builds with the .NET 10 SDK (global.json 10.0.403) and C# 14. The tool and its tests target net10.0, and CI runs the tests on net10.0 only.

After: the repo builds with the .NET 11 SDK (11.0.100) and C# 15. The tests target net10.0 and net11.0, and CI runs them as a net10.0/net11.0 matrix. The artclean tool package stays on net10.0.

How: global.json pins 11.0.100, rolls forward within 11.x (latestMinor) and excludes prereleases. It isn't latestMajor because actions/setup-dotnet then ignores the version and installs the LTS SDK (10.0.x), which breaks GitHub's NuGet dependency submission. LangVersion is 15. CI adds an 11.0.x setup-dotnet step after the existing 10.0.x one, which still provides the runtime for net10.0 tests. TestProjects gets a test-framework matrix. The tool stays single-target because its RID-specific Native AOT packages put files under tools/any/<rid> with no framework folder, so a second target framework fails dotnet pack with NU5118. Invex.Atom.Tool does the same. The build uses Atom 5.2.0: _atom/_atom.csproj references Invex.Atom.Module.GitHubWorkflows and Invex.Atom.Module.GitVersion 5.2.0, which is on NuGet and supersedes the never-published 5.1.0. The 11.0.x step is BuildOptions.Steps.SetupDotnet.Dotnet110X(), the matrix uses WorkflowLabels.Dotnet.Framework.Net_11_0, and regenerating the workflows after the move gave no diff. The BuildVersion fix going into the other repos isn't needed here: this PushToNuget pushes every staged .nupkg and doesn't pick by version. Workflows are regenerated with atom Gen, and the README and AGENTS.md describe the targets.


Generated by Claude Code

Pins SDK 11.0.100-rc.2.26504.105 in global.json (prereleases allowed,
latest-feature roll-forward), sets LangVersion 15, and adds a CI step that
installs the RC2 SDK next to the .NET 10 SDK, which still provides the
runtime for net10.0 tests. Target frameworks are unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Pins SDK 11.0.100 in global.json (stable only, latest-major roll-forward,
matching main) and installs 11.0.x in CI instead of the release candidate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 00:09
@DecSmith42 DecSmith42 self-assigned this Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The README omits the .NET 10 runtime prerequisite, so users installing only the documented .NET 11 SDK cannot launch the Atom commands.

1 open issue
What changed in this PR

Updates the repository’s build tooling to the .NET 11 SDK and C# 15 while leaving target frameworks and published packages unchanged.

Changes:

  • Pins SDK 11.0.100 and sets the language version to C# 15.
  • Adds .NET 11 setup to Atom-generated workflows while retaining .NET 10 for runtime compatibility.
  • Updates the README’s contributor SDK prerequisite.
File Description
README.md Names .NET 11 as the required development SDK.
global.json Selects SDK 11.0.100 with existing roll-forward settings.
Directory.Build.props Sets C# language version to 15.
.github/​workflows/​Validate.yml Adds .NET 11 setup to validation jobs.
.github/​workflows/​Dependabot Enable auto-merge.yml Adds .NET 11 setup for Dependabot automation.
.github/​workflows/​Cleanup Prereleases.yml Adds .NET 11 setup for prerelease cleanup.
.github/​workflows/​Build.yml Adds .NET 11 setup to build, release, and documentation jobs.
_atom/​IBuild.cs Defines the shared .NET 11 setup step alongside .NET 10.

Review effort: Balanced

Comment thread README.md Resolved
actions/setup-dotnet ignores the version when rollForward is latestMajor and
installs the LTS SDK (10.0.x), which can't satisfy 11.0.100. That broke
GitHub's NuGet dependency submission scan. latestMinor makes it install 11.x.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 00:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The SDK roll-forward policy narrows to 11.x despite the stated intent, and the prerequisites omit the .NET 10 runtime required to run tests and Atom commands.

2 open issues

Review effort: Balanced

Comment thread global.json Resolved
The net10.0 tests and the Atom build project need the .NET 10 runtime, which
the .NET 11 SDK doesn't include.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 00:24
Copilot AI previously approved these changes Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues were identified for the .NET 11 SDK and C# 15 toolchain update.

1 open issue
1 resolved since last review

Review effort: Balanced

@DecSmith42
DecSmith42 marked this pull request as ready for review November 11, 2026 00:29
The ArtifactClean tests now target net10.0 and net11.0, and CI runs
TestProjects as a net10.0/net11.0 matrix (it previously ran net10.0 only).

The tool itself stays on net10.0: its RID-specific Native AOT packages put
files under tools/any/<rid> with no framework folder, so a second target
framework collides when packing (NU5118). Atom's own tool does the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 01:56
@DecSmith42 DecSmith42 changed the title Build with the .NET 11 SDK and C# 15 Build with .NET 11 and test on net11.0 Nov 11, 2026
Copilot AI previously approved these changes Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The .NET 11 SDK and C# 15 update has no active review issues.

1 open issue

Review effort: Balanced

Uses Atom's Dotnet110X step and Net_11_0 framework label in place of the interim literals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Copilot AI balanced review requested due to automatic review settings November 11, 2026 05:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues block the SDK and test-targeting changes.

1 open issue

Review effort: Balanced

@DecSmith42
DecSmith42 merged commit 684d51b into main Nov 11, 2026
18 checks passed
@DecSmith42
DecSmith42 deleted the claude/project-thread-h7vtsx branch November 11, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants