Repository navigation
Fix Rust test discovery, docs, binaries, CI, and clippy - #1
Merged
Merged
Conversation
One classifier decides which paths are test files. Rust files under tests/ count, and #[test]-family functions are test units even inside source files. suggest-tests, diff-impact, test-gaps, and risk-map then answer a normal crate, including this repo. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
library.md, file_health.md, and file_health.json mapped the deleted Python package and cannot be regenerated here. plan.md no longer points at a missing PLAN_NEXT.md. The short architecture docs now name the Rust modules. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
chisel-mcp is a thin binary instead of a second target on src/main.rs. Directory walk helpers used only by inotify or kqueue are compiled for those platforms. --version prints the package version. monitored_paths.txt held one local absolute path and is untracked. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
The macOS and Windows jobs were release builds only. Shell-script extractor tests stay on Unix, where those scripts run. Test repos turn off commit signing and autocrlf so the frozen oracle hashes stay stable, and UTC git dates are stored with a Z suffix. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
Collapse nested conditions, name the wide risk and churn and reviewer types, and keep the lock file from being truncated on open. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Chisel findings from the 3 Nov 2026 review. Each item was checked in the tree before the change.
is_test_file.looks_like_testis the only filename check, and the empty-analyze hint uses that same pattern list..rsfiles under the top-leveltests/directory are test files.#[test],#[tokio::test],#[rstest], and#[test_case]functions are test units even inside source files.risk-mapandtest-gapsstill treat those source files as code and skip the test functions. Fixture:tests/fixtures/rust_crate. Dogfood:suggest-tests src/engine/analyze.rson this repo returns atests/*.rsfile, andrisk-mapdoes not listtests/paths as code.library.md,file_health.md, andfile_health.json(wikifier maps of the deleted Python package; nothing here can regenerate them) and the emptypending_updates.md.plan.mdno longer points at a missingPLAN_NEXT.md.ARCHITECTURE.md,CLAUDE.md, andCOMPLETE_PROJECT_DOCUMENTATION.mddescribe the Rust modules.AGENTS.mdnow includestests/*.rsand#[test].collect_files,collect_dirs, andskip_dirare compiled only for the platforms that call them.chiselstayssrc/main.rs.chisel-mcpissrc/bin/chisel-mcp.rs.cargo testbefore the release build. Shell-script extractor tests are#[cfg(unix)]so the Windows compile does not require a POSIX shell.--versionand the local path.chisel --versionandchisel-mcp --versionprint the package version. Deletedmonitored_paths.txt(/home/aron/Documents/coding_projects/Chisel). The binary does not read that file.cargo clippy --all-targetsis clean on the host, including a release clippy run.Measured checks
cargo test -- --test-threads=8: 82 passed, 0 failed (lib 7, durability 4, extract_parity 2, oracle_parity 4, rust_layout 4, scale 57, surface_contract 4).cargo buildandcargo build --release: exit 0, no warnings. Release binaries printchisel 0.16.1.cargo clippy --all-targetsandcargo clippy --all-targets --release: exit 0, no warnings..github/workflows/ci.yml: empty dependency tables,dependency_count 0.cargo build --release --target x86_64-unknown-linux-musl: exit 0.cargo check --target x86_64-pc-windows-msvc --tests: exit 0, no warnings.Not run here
macOS and Windows GitHub runners were not executed in this environment. The Windows target typecheck covers compilation of the tests, not their runtime. The musl job's
apt-get install musl-toolsstep was run locally so the musl release build could be checked.