Skip to content

Fix Rust test discovery, docs, binaries, CI, and clippy - #1

Merged
IronAdamant merged 5 commits into
mainfrom
cursor/chisel-review-fixes-43b6
Nov 3, 2026
Merged

IronAdamant merged 5 commits into
mainfrom
cursor/chisel-review-fixes-43b6

Conversation

@IronAdamant

Copy link
Copy Markdown
Owner

Summary

Fixes the Chisel findings from the 3 Nov 2026 review. Each item was checked in the tree before the change.

  1. One test-file classifier. Deleted the unused is_test_file. looks_like_test is the only filename check, and the empty-analyze hint uses that same pattern list. .rs files under the top-level tests/ directory are test files. #[test], #[tokio::test], #[rstest], and #[test_case] functions are test units even inside source files. risk-map and test-gaps still treat those source files as code and skip the test functions. Fixture: tests/fixtures/rust_crate. Dogfood: suggest-tests src/engine/analyze.rs on this repo returns a tests/*.rs file, and risk-map does not list tests/ paths as code.
  2. Docs match the Rust crate. Removed library.md, file_health.md, and file_health.json (wikifier maps of the deleted Python package; nothing here can regenerate them) and the empty pending_updates.md. plan.md no longer points at a missing PLAN_NEXT.md. ARCHITECTURE.md, CLAUDE.md, and COMPLETE_PROJECT_DOCUMENTATION.md describe the Rust modules. AGENTS.md now includes tests/*.rs and #[test].
  3. Build targets. collect_files, collect_dirs, and skip_dir are compiled only for the platforms that call them. chisel stays src/main.rs. chisel-mcp is src/bin/chisel-mcp.rs.
  4. CI. The macOS arm64, macOS x64, and Windows jobs run cargo test before the release build. Shell-script extractor tests are #[cfg(unix)] so the Windows compile does not require a POSIX shell.
  5. --version and the local path. chisel --version and chisel-mcp --version print the package version. Deleted monitored_paths.txt (/home/aron/Documents/coding_projects/Chisel). The binary does not read that file.
  6. Clippy. cargo clippy --all-targets is clean on the host, including a release clippy run.

Measured checks

  • cargo test -- --test-threads=8: 82 passed, 0 failed (lib 7, durability 4, extract_parity 2, oracle_parity 4, rust_layout 4, scale 57, surface_contract 4).
  • cargo build and cargo build --release: exit 0, no warnings. Release binaries print chisel 0.16.1.
  • cargo clippy --all-targets and cargo clippy --all-targets --release: exit 0, no warnings.
  • CI dependency check from .github/workflows/ci.yml: empty dependency tables, dependency_count 0.
  • cargo build --release --target x86_64-unknown-linux-musl: exit 0.
  • cargo check --target x86_64-pc-windows-msvc --tests: exit 0, no warnings.

Not run here

macOS and Windows GitHub runners were not executed in this environment. The Windows target typecheck covers compilation of the tests, not their runtime. The musl job's apt-get install musl-tools step was run locally so the musl release build could be checked.

Open in Web Open in Cursor 

cursoragent and others added 5 commits November 3, 2026 05:18
One classifier decides which paths are test files. Rust files under tests/ count, and #[test]-family functions are test units even inside source files. suggest-tests, diff-impact, test-gaps, and risk-map then answer a normal crate, including this repo.

Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
library.md, file_health.md, and file_health.json mapped the deleted Python package and cannot be regenerated here. plan.md no longer points at a missing PLAN_NEXT.md. The short architecture docs now name the Rust modules.

Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
chisel-mcp is a thin binary instead of a second target on src/main.rs. Directory walk helpers used only by inotify or kqueue are compiled for those platforms. --version prints the package version. monitored_paths.txt held one local absolute path and is untracked.

Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
The macOS and Windows jobs were release builds only. Shell-script extractor tests stay on Unix, where those scripts run. Test repos turn off commit signing and autocrlf so the frozen oracle hashes stay stable, and UTC git dates are stored with a Z suffix.

Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
Collapse nested conditions, name the wide risk and churn and reviewer types, and keep the lock file from being truncated on open.

Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
@IronAdamant
IronAdamant merged commit 4122fa8 into main Nov 3, 2026
5 checks passed
@IronAdamant
IronAdamant deleted the cursor/chisel-review-fixes-43b6 branch November 3, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants