Repository navigation
Fix the Rust map, wiki checks, tests, and CI from the 3 Nov review - #5
Merged
Merged
Conversation
use wikifier::... from src/main.rs and tests/*.rs was dropped because resolve_rust only kept mod and crate::. Read the root Cargo.toml package and lib names, resolve self:: and super:: from the file, and keep crate:: inside that file's crate. A Cargo-layout fixture and a prepare-edit dogfood check on this repo's src/api.rs lock the dependent set. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
The section cited scripts/benchmark_lookup.py and numbers from the Python package. That script is not in this repo, so the figures cannot be reproduced. The performance table that remains already says it measured the Python package. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
mark-green now extracts pub fn, struct, enum, trait, mod, type, const,
static, and pub use names. pub(crate) and impl methods stay out of the
check, so a Rust file can be verified Green. Go, C, C#, and Java stay
unchecked. Char escapes such as '\u{1e}' no longer confuse the scan.
Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
…ce edges. WIKIFIER_MCP_DEADLINE_S stops a blocking monitor call and still finishes health. A cap of 1 truncates check-changes and names the env var. An empty cache imports import_cache.sqlite, a filled cache does not, and a corrupt sqlite file warns sqlite_present_unread. Conditional edges are actionable; dynamic edges are not. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
CI and the release workflow use dtolnay/rust-toolchain@1.83.0 instead of @stable. Ubuntu, macOS, and Windows all run cargo test --locked, and a Windows failure fails the workflow. The sqlite import assertions still run wherever the sqlite3 CLI is installed; the unread warning runs on every platform. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
Drop the dead list-paths loop and the clippy findings in the library and the binary. Move the two Python-era plans to Findings/archive and delete the wiki for the removed Python test. Refresh the dependency map and mark the touched Rust wikis verified. Co-authored-by: Aron Amos <IronAdamant@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3 Nov review's wikifier findings are fixed at the cause, after checking each one in this tree.
Rust imports
resolve_rustonly keptmodandcrate::, souse wikifier::...fromsrc/main.rsandtests/*.rsnever became an edge. The resolver now reads the rootCargo.tomlpackage name and lib name (hyphens become underscores), and it resolvescrate::,self::, andsuper::from the file.crate::stays inside that file's crate (tests/*.rsandsrc/bin/*.rsincluded). The package or lib name points at the library. Path expressions with the same shape count too.A Cargo-layout fixture (
src/lib.rs,src/main.rs,src/bin/,tests/) is part ofaccuracy_fixtures_match_frozen_edges. A dogfood test copies this repo, runsupdate_maps, and checksprepare_editonsrc/api.rs. The dependents aresrc/lib.rs,src/mcp.rs,src/main.rs,tests/cli_surface.rs,tests/contract_gaps.rs,tests/protocol_v07.rs,tests/robustness.rs, andtests/skip_maps.rs.README benchmark
The "Does it pay off?" section cited
scripts/benchmark_lookup.pyand numbers from the Python package. That script is not in this repo, so the section is gone. The performance table that remains already says those numbers are from the Python package.Rust Green
mark-greennow checks top-level Rustpubitems:fn,struct,enum,trait,mod,type,const,static, andpub usenames.pub(crate)and items insideimplare not in that set. A Rust file can beverified. Go, C/C++, C#, and Java stayunchecked. On this repo,verify-wikischecked 29 Green wikis with 0 failures.health --summaryreports 16 verified, 9 unchecked, 0 red.Behaviour tests
tests/behaviour_gaps.rscovers:WIKIFIER_MCP_DEADLINE_S: ahealthcall finishes, a blockingmonitorcall returnsDeadlineExceededwithtimed_outandmay_still_complete, and0still waits at least one second.WIKIFIER_CHECK_CHANGES_MAX: a cap of 1 setstruncatedand names the variable. A larger cap and a non-numeric value do not.sqlite_present_unread. When thesqlite3CLI is on PATH, an empty cache importsfilesandedgeswith hashsha256:legacy, and a filled cache is left alone.actionable_low_conf_edges: a conditional import is included at confidence 0.55 (conditional_guard). A dynamicimport_moduleis not.CI
.github/workflows/ci.ymlandpublish.ymlpindtolnay/rust-toolchain@1.83.0. Ubuntu, macOS, and Windows all runcargo test --locked. The Windows job is required. The sqlite import assertions run wheresqlite3is installed; the unread warning runs everywhere, so a Windows image without the CLI still exercises that path.Tidy
Deleted
tests/test_gap_closure.py.wiki.md. Cleared the clippy warnings (cargo clippy --all-targets -- -D warningsis clean), including the unused import intests/parity.rs. MovedMODULARIZATION_PLAN.mdandSIMPLIFICATION_PLAN_AND_LOG.mdtoFindings/archive/. Refreshedlibrary.md(74 edges,map_completetrue).Measured here
cargo build: successcargo test --locked: 47 passed, 0 failed, 0 ignoredcargo clippy --all-targets -- -D warnings: successcargo test --locked, the empty-dependencyawkcheck, andcargo run --quiet -- --version(wikifier 4.7.0)verify-wikis: 29 checked, 0 failed