Repository navigation
Hide managed Chrome windows on Windows - #21
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughManaged Windows Chrome now hides ordinary windows after isolated-tab setup. Human authentication, challenge, and recovery flows restore windows through PID-based control, with CDP fallback behavior retained. ChangesWindows Chrome visibility
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change hides managed Chrome windows while preserving intentional recovery visibility, with validation and Windows dogfood completed; no actionable merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant BrowserOrchestration
participant ChromeLifecycle
participant PowerShellUser32
participant CDPFallback
BrowserOrchestration->>ChromeLifecycle: hide managed Chrome by PID
ChromeLifecycle->>PowerShellUser32: hide matching Chrome windows
PowerShellUser32-->>ChromeLifecycle: return visibility result
ChromeLifecycle-->>BrowserOrchestration: return success boolean
BrowserOrchestration->>ChromeLifecycle: restore Chrome by PID
ChromeLifecycle->>PowerShellUser32: restore matching Chrome windows
PowerShellUser32-->>ChromeLifecycle: return restoration result
BrowserOrchestration->>CDPFallback: normalize target when PID restoration fails
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 4 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Summary
SW_HIDEafter every isolated-tab setupSW_RESTOREtransitions so concurrent unattended runs preserve only intentional login/challenge/recovery visibilityRoot cause
PR #19 changed Windows process brokering and priority, but parking still depended on PR #18's DevTools minimize transition. Live probing with two concurrent leases showed the managed
Chrome_WidgetWin_1window was visible, normal, and uncloaked. A first native-hide attempt also proved that creating a later isolated tab can make the HWND visible again, so each ordinary setup must re-hide it while preserving explicitly restored human-recovery windows.Validation
pnpm run buildpnpm run lintpnpm test(19 files, 281 tests)pnpm run format:checkpnpm pack --dry-runClicked send button; all three harvested their exact responses; each setup logged native hide; live HWND probe after concurrent tab creation showedVisible=false,Minimized=false; first completion left two leases and shared Chrome alive; final completion left zero leases and zero managed descendantsSummary by CodeRabbit
New Features
Documentation