Nova compatibility expansion#8
Draft
JSYoo5B wants to merge 14 commits into
Draft
Conversation
JSYoo5B
commented
Jul 2, 2026
| idGen idgen.Generator | ||
| } | ||
|
|
||
| func NewServiceWithRuntime( |
Owner
Author
There was a problem hiding this comment.
Compute now has several independent repositories, but the constructor keeps those dependencies explicit. This is verbose, yet useful for tests and for later disabling or replacing resource families.
JSYoo5B
commented
Jul 2, 2026
| }) | ||
| } | ||
|
|
||
| func (h Handler) updateServerMetadata(w http.ResponseWriter, r *http.Request) { |
Owner
Author
There was a problem hiding this comment.
Metadata is a good representative for Nova mutation endpoints: handlers stay wire-focused while merge/reset behavior lives in the app service. The metadatum handlers below are the same pattern at single-key granularity.
JSYoo5B
commented
Jul 2, 2026
| return | ||
| } | ||
|
|
||
| key := chi.URLParam(r, "key") |
Owner
Author
There was a problem hiding this comment.
This explicit key/body match check protects the OpenStack wire contract for single metadata updates. It is worth reviewing because Gophercloud callers will surface mismatches as client-visible bad requests.
JSYoo5B
force-pushed
the
codex/06-keystone-read-repository-state
branch
from
9275327 to
7e58142
Compare
JSYoo5B
force-pushed
the
codex/07-nova-compatibility-expansion
branch
from
0ef73a7 to
254fa50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main Review Points
Verification