Skip to content

Fix deletion of footnote and endnote references - #48

Merged
JSv4 merged 1 commit into
mainfrom
fix/44-delete-note-references
Sep 17, 2026
Merged

JSv4 merged 1 commit into
mainfrom
fix/44-delete-note-references

Conversation

@JSv4

@JSv4 JSv4 commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Deleting a footnote or endnote marker now removes its native definition and reference together, preserves surrounding text, and supports one-step undo/redo. Selections retain note identities separately from text offsets; browsers without deletion target ranges use the adjacent DOM reference. Note-only paragraphs remain editable.

Closes #44.

Validation:

  • Confirmed the native-note deletion regression failed before the fix; added parameterized caret/selection cases, save/reopen, mixed-note boundaries, empty paragraphs, and missing/empty browser target ranges.
  • Lint, TypeScript, 82 unit tests, library/demo builds, API checks, and packed-consumer checks pass.
  • Full browser suite: 63 passed; 2 optional NVCA stress/performance tests skipped by the existing configuration.
  • Adversarially reviewed with gpt-5.6-sol; reproduced and fixed its compatibility finding, then received a clean re-review.

@JSv4
JSv4 merged commit 30af90d into main Sep 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting Footnote/Endnote Doesn't work

1 participant