Repository navigation
Send mDNS from UDP 5353 - #28
Merged
Merged
Conversation
…IA#102) fix(mdns): send responses from UDP 5353 (GitHub Issue NVIDIA#1) Summary Bind mDNS responses, announcements, goodbyes, and supplemental discovery queries to UDP source port 5353. Preserve per-interface sending and platform-specific socket sharing. Add source-port regression tests, architecture documentation, and native Linux, Windows, and macOS CI coverage. (cherry picked from commit bda6d87) Co-authored-by: sherief-nv <41652522+sherief-nv@users.noreply.github.com> Signed-off-by: Jared Ping <13906915+JaredP94@users.noreply.github.com>
JaredP94
force-pushed
the
fix/mdns-source-port
branch
from
November 2, 2026 18:46
c264ada to
8aff59e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mDNS responses, announcements, goodbyes and the supplemental discovery query now go out from UDP source port 5353 (RFC 6762), so responders and firewalls that ignore other source ports see them (NVIDIA#44). Darwin needs
SO_REUSEPORTto share 5353 with mDNSResponder.Cherry-picked from NVIDIA/Personal-AI-Router@bda6d87 (NVIDIA#102). This fork's
shared/discoveryandshared/mdnswere unchanged since the fork point, so it applied cleanly.Scope
services/shared/{discovery,mdns}; rebuilt into the scanner and cluster manager.This does not address the per-scan socket churn suspected in NVIDIA#19 / NVIDIA#59 — a socket per send still opens and closes. That needs measurement before changing.
Validation
go testinshared/mdns,shared/discovery,nvpair-node-scanner,nvpair-cluster-manager.en0and the Tailscaleutunalongside a running mDNSResponder.Risk
Low. Scanner 1.2.1, cluster-manager 2.1.1.
Checklist
git commit -s), certifying the Developer Certificate of Origin.services/versions.json, and described user-visible changes above so they reach the release notes.Part of the upstream issue/PR review. Each branch is independent off
main; they all bumpservices/versions.json, so the second one merged will need a trivial conflict resolution there.