You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(hip): HIPv2-only parameters are accepted inside HIPv1 packets #1133
Describe the bug
Only two HIP parameters check the packet's HIP version: R1_Counter (hip.py:3053) and HIP_TRANSFORM (hip.py:1343). Four parameters that RFC 7401 introduces for HIPv2 build and parse inside a HIPv1 packet with no warning:
DH_GROUP_LIST (511)
HIP_CIPHER (579)
HIT_SUITE_LIST (715)
TRANSPORT_FORMAT_LIST (2049)
The v2 forms of PUZZLE and SOLUTION may have the same gap.
Reproduction
The #1128 reviewer forced every generated HIP code to version 1 and ran make_samples.py. All four built and parsed back at v1, and none of them warned.
Expected behavior
Warn on a version mismatch the same way R1_Counter and HIP_TRANSFORM already do.
Blocked until #1111 and #1118 merge, since both edit pcapkit/protocols/internet/hip.py or its schema.
Additional context
Low severity. This affects strict HIPv1 conformance only. The #1128 cross-review found it.
Activity
JarryShaw commentedon Oct 6, 2026
Unblocked: #1111 and #1132 (the #1118 fix) have both merged, so
hip.pyand its schema are free. A worker is on it now.