Skip to content

fix(tcp): bytes after EOOL are dropped and the Data Offset is recomputed, shrinking the header #1218

New issue
New issue
Closed
#1348
Closed
fix(tcp): bytes after EOOL are dropped and the Data Offset is recomputed, shrinking the header#1218
#1348
Labels
fixPull requests that fix a defect (fix: subject prefix)
Milestone
PyPCAPKit v1.5

Description

@JarryShaw
JarryShaw
opened on Oct 7, 2026

Describe the bug
transport/tcp.py:744 stops parsing at EOOL without recording what follows it, and make recomputes the offset from the parsed options (:610), ignoring info.hdr_len.

To Reproduce
Options 00010101 020405b4 at Data Offset 7 rebuild as 00000000 at Data Offset 6, so the payload boundary moves by 4 octets.

Expected behavior
The octets after EOOL are kept and the header rebuilds at its original length.

Found by the transport round-trip audit (#1202). I re-ran the repro on main at 630f0a581.

Activity

  1. JarryShaw
    added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  2. JarryShaw
    added this to PyPCAPKiton Oct 7, 2026

  3. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Blocked until the MPTCP PR for #1212–#1217/#1220 merges, because both edit transport/tcp.py and its schema and data modules.

  4. JarryShaw
    added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026

  5. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Unblocked: #1254 merged at 19:08Z, so the file conflict is gone. Back to pending until a worker picks it up.

  6. JarryShaw
    added
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  7. JarryShaw
    added 2 commits that reference this issue on Oct 7, 2026

    fix(tcp)!: reserved bits, post-EOOL octets and the UTO granularity ro…

    72615ea

    fix(tcp)!: reserved bits, post-EOOL octets and the UTO granularity ro…

    51eb712
  8. JarryShaw
    closed this as completedin #1348on Oct 7, 2026
  9. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 7, 2026
  10. JarryShaw
    added this to the PyPCAPKit v1.5 milestone on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions