Skip to content

fix(ftp): a complete multi-line reply in one segment does not parse #1303

New issue
New issue
Closed
#1347
Closed
fix(ftp): a complete multi-line reply in one segment does not parse#1303
#1347
Labels
fixPull requests that fix a defect (fix: subject prefix)
Milestone
PyPCAPKit v1.5

Description

@JarryShaw
JarryShaw
opened on Oct 7, 2026

Describe the bug
The FTP parser handles one line per segment. A full multi-line reply (RFC 959 §4.2) that arrives in a single segment is rejected.

To Reproduce
FTP(b'220-a\r\n220 b\r\n') raises ProtocolError: FTP: invalid packet format.

Expected behavior
The reply parses, keeping every line, and rebuilds byte-exactly.

Found by the #1301 worker.

Found by the application round-trip audit (#1202). The repro was re-checked by an independent verifier, and I re-ran it on main at 11ae68ebf.

Activity

  1. JarryShaw
    added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026

  2. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Blocked until #1301 merges, because both edit ftp.py/httpv1.py and their data models.

  3. JarryShaw
    added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  4. JarryShaw
    added this to PyPCAPKiton Oct 7, 2026
  5. JarryShaw
    moved this to Blocked in PyPCAPKiton Oct 7, 2026

  6. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Unblocked: #1301 merged at 19:09Z, so the file conflict is gone. Back to pending until a worker picks it up.

  7. JarryShaw
    added
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  8. JarryShaw
    added a commit that references this issue on Oct 7, 2026

    fix(ftp,httpv1): keep the raw command case, HTTP/1 whitespace and fie…

    5017fb9
  9. JarryShaw
    closed this as completedin 0a32b2fon Oct 7, 2026
  10. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 7, 2026
  11. JarryShaw
    added this to the PyPCAPKit v1.5 milestone on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions