Repository navigation
test: drop the SMF_DPD 0x23 exclusion and a stale line reference #1771
Description
Describe the bug
Two test-only leftovers:
tests/protocols/internet/test_smf_dpd_truncated_len_unit.py:24-25keepsEXCLUDED = {0x23}, with the comment "tracked in fix(ipv6-opts): RPL option 0x23 raises AttributeError in _read_opt_unassigned #1196". fix(ipv6-opts): RPL option 0x23 raises AttributeError in _read_opt_unassigned #1196 is closed, by fix(schema): SMF_DPD option at the end of the header raises TypeError from smf_i_dpd_id_len #1197 and fix(ipv6-opts): RPL option 0x23 raises AttributeError in _read_opt_unassigned #1198. HOPOPT and IPv6_Opts givenPREFIX + b'\x23\x00'both raise the library'sProtocolError, so the loop would pass for 0x23.tests/test_docstring_contract.py:238: aKnown(...)reason string citespcapkit/vendor/default.py:288.Vendor.contextis now at:417.
Expected behavior
Drop the exclusion and its comment, and update the line reference.
Additional context
Found by the #1103 tests-slice worker and verified by a Sonnet review. These are string and set literals, so the prose-only sweep cannot change them.
Activity
JarryShaw commentedon Oct 15, 2026
The
test_docstring_contract.py:238line reference is being fixed in the #1103 round-2 internet slice, together with the twoipv4.pyentries in that file. Those three changes have to land together. This issue keeps the SMF_DPD0x23exclusion.JarryShaw commentedon Oct 15, 2026
A worker is on this.
test: exercise option type 0x23 in the SMF_DPD truncation loop (#1771) (