Skip to content

test: the PCAP-NG JSON report test is still skipped after #1158 fixed its cause #1795

Closed

Description

@JarryShaw

Describe the bug
tests/integration/test_pcapng_end_to_end.py:177-179 skips PcapngUnescapedKeyTests.test_json_report_of_a_decryption_secrets_block_parses as "blocked on dictdumper". #1152 closed through #1158, which escapes JSON mapping keys inside pcapkit (escape_json_keys and escape_key, pcapkit/dumpkit/common.py:346 and :366). Run without the skip, the test passes, and it is not vacuous: it asserts five frames and the block's name in the report.

Expected behavior
The skip is removed. The class and test docstrings (lines 170-210), which still say the report is unparseable and cite pcapng.py:2244 and common.py:351, are rewritten in the same change.

Additional context
dictdumper 0.8.4.post6 still writes the key raw, so the upstream defect is real but worked around. Found by the #1103 second pass (tests slice) and confirmed by a Sonnet review.

Activity

  1. added
    testPull requests that add or correct tests (test: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  2. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    OwnerAuthor

    A worker is on this.

  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  4. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 16, 2026
  5. added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testPull requests that add or correct tests (test: subject prefix)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions