Repository navigation
fix(corekit): SeekableReader reopens its NamedTemporaryFile by name, which Windows refuses #2098
Description
Job 120605026883, the first Windows run of #2095's leg: SeekableReaderTests.test_buffer_save_default_path_and_rollover_reads and test_saved_readline_and_empty_buffer_refill_edges fail with PermissionError: [Errno 13] at open(self._buffer_path, 'rb').
With buffer_save=True and no buffer_path, SeekableReader.__init__ creates a NamedTemporaryFile('wb', buffering=0) and later reopens it by name. Windows refuses to open a NamedTemporaryFile a second time while it is open, so --buffer-save breaks there.
Proposed: delete=False (or mkstemp) and unlink in close(). This is a #2060 phase-2 prerequisite.
Activity
fix(corekit): let Windows reopen SeekableReader's buffer file (#2098) (…