Repository navigation
fix(foundation): Extractor keeps its input open when the constructor's run() raises #2100
Description
Job 120605026883, the first Windows run of #2095's leg: test_a_packet_block_before_any_interface_fails_as_from_a_file hits WinError 32 when deleting capture.pcap.
When the engine raises FormatError out of Extractor.__init__ → run → record_frames, only a KeyboardInterrupt calls _cleanup(), so the opened input stays open until GC. The exception the test holds keeps it alive. POSIX hides this because an open file can still be unlinked.
Proposed: in __init__, wrap self.run() as try: ... except BaseException: self._cleanup(); raise.
Activity
fix(foundation): close the input when the Extractor constructor raises (