Repository navigation
test(foundation): close the patched-run Extractor before its TemporaryDirectory exits #2101
Description
Job 120605026883, the first Windows run of #2095's leg: 7 tests/foundation/test_extraction.py::ExtractorTests cases fail with WinError 32 on sample.pcap. They are the dict_capable…, real_frames…, auto_mode_call…, constructor_initialises…, pcap_trace_format_is_replaced… and the two warns_bullet_… cases.
With run patched out, _traced and its siblings close extractor._ifile through addCleanup or after the with TemporaryDirectory() block, so the directory is deleted while the file is still open. This is test-only; the library is fine here.
Proposed: close _ifile inside the with block.
Activity
test(foundation): close the patched-run Extractor inside its Temporar…
JarryShaw commentedon Oct 23, 2026
Fixed on
mainas41cdf1759(test-only): the sevenExtractorTestscases now closeextractor._ifileinside theirTemporaryDirectory.test_extraction_tempdir_close_2101_unitmakesTemporaryDirectory.cleanupfail as Windows does while a file in the directory is open; it fails on all seven without the change and passes with it.