Skip to content

test(tier-guard): the bash steps run WSL's bash.exe on Windows #2103

Closed

Description

@JarryShaw

Job 120605026883, the first Windows run of #2095's leg: 4 tests/test_tier_guard.py::WorkflowAgreementTests cases fail with Windows Subsystem for Linux has no installed distributions.

The skip guard checks shutil.which('bash'), which finds Git Bash. subprocess.run(['bash', …]) resolves System32's bash.exe, the WSL launcher, first.

Proposed: run the absolute path that which returned (in stubbed_argv and leg_ignores), or skip on nt.

Activity

  1. added
    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)
    testPull requests that add or correct tests (test: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 23, 2026
  2. moved this to Pending in PyPCAPKiton Oct 23, 2026
  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 23, 2026
  4. moved this from Pending to WIP in PyPCAPKiton Oct 23, 2026
  5. JarryShaw commented on Oct 23, 2026

    @JarryShaw
    OwnerAuthor

    Fixed on main as 862a6e679 (test-only): the skip guards and stubbed_argv run the absolute path shutil.which('bash') returns. test_tier_guard_bash_path_2103_unit puts a WSL-style bash first on PATH and fails without the change. Not verified on Windows: whether Git Bash then runs the extension-less python stub. The next Windows leg run will show it.

  6. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 23, 2026
  7. added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)testPull requests that add or correct tests (test: subject prefix)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions