Repository navigation
perf(foundation): the Extractor probes the pcap backend three times per extraction #2113
Description
Found while profiling #2110. Each extraction probes the pcap backend three times. Extractor._select_engine calls unsupported_reason twice, and the constructor probes once more. Each probe scans the installed distributions. After #2112 a scan costs about 115 µs, so the probes take around 0.35 ms of a roughly 0.64 ms extraction of the 6-packet in.pcap (3.15, Docker).
Proposed: probe once per extraction, or cache the result for the process, as long as installing a package mid-process doesn't need noticing. Then re-measure with examples/benchmark/run.sh. This touches pcapkit/foundation/extraction.py, so it waits for #2104 and #2106.
Activity
perf(foundation): probe the pcap backend once per extraction (#2113) (#…
fix(foundation): close the engine too when the Extractor constructor …
fix(foundation): close the engine too when the Extractor constructor …