Skip to content

test(project): verbatim text pins block fixing change-relative and wrong prose #2228

Closed

Description

@JarryShaw

Is your feature request related to a problem? Please describe.
These tests pin prose verbatim, so the prose cannot be reworded to describe current behaviour without editing the pin as well:

  • test_docs_internal_refs_1947_unit CONVERTED requires "dropped" + the TransportProtocol role, from "reg: drop TransportProtocol's IntFlag base once nothing builds a composite #808 dropped TransportProtocol's IntFlag base" in the apptype vendor and const modules.
  • test_const_method_value_lookup_908_unit requires "value were both the :class:bytes object" in the Method.get docstring, in the source and in the rendered template.
  • test_docs_internal_refs_1940_unit CONVERTED requires the compat.cached_property role on sentinel-convention.rst, where the prose calls it the "backport" that Require Python 3.8+ and drop the BPC conversion for 1.5.0 #2051 removed. compat.cached_property is now a functools re-export.
  • test_issue_refs_in_comments META_MENTIONS pins the comment ":ref: half passed before the change too" in test_changelog_md's test_an_unknown_role_is_still_fatal; rewording it fails with "stale META_MENTIONS entries".
  • test_unit_tests_queue BARE_ELSEWHERE pins :631-647 in releasing.rst, a line citation of third-party code. Those lines are in release() in action-gh-release 3.0.2's src/github.ts.

Describe the solution you'd like
Reword each sentence and update its pin in the same PR. Cite the action by function name (release()), then drop the BARE_ELSEWHERE entry. Where a pin only guards a role conversion, pin the role instead of the sentence around it.

Additional context
Found while verifying #1103 prose fixes.

Activity

  1. added
    docsPull requests that change documentation only (docs: subject prefix)
    testPull requests that add or correct tests (test: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 26, 2026
  2. added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
  3. JarryShaw commented on Oct 26, 2026

    @JarryShaw
    OwnerAuthor

    Closed by #2242 (four of the five pins) and #2249 (the releasing.rst citation and its BARE_ELSEWHERE entry), both merged.

  4. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsPull requests that change documentation only (docs: subject prefix)testPull requests that add or correct tests (test: subject prefix)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions