You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(esp): ESP error messages lack the ESP: prefix and mostly print values without !r #2297
Describe the bug
None of the ProtocolError messages in pcapkit.protocols.internet.esp follows the <prefix>: <lowercase description>: … {value!r} form that #2232 and #2257 applied to Ethernet, PCAP-NG and ARP. They have no ESP: prefix, some put "ESP" in the middle of the sentence, and most print the value bare. Even _resolve is inconsistent with itself: one branch has {value} and the other {value!r}.
Expected behavior ESP: unsupported encryption algorithm: 'ENCR_3DES'; … and ESP: invalid SPI: -1. One sweep over the module covers it: _resolve, CipherSuite.get, IntegritySuite.get, SecurityAssociation.__init__ (SPI, destination, AEAD-plus-integrity, ICV length), SecurityAssociation.unavailable / compute_icv / decrypt / encrypt / _split_key (this includes the "needs the optional "cryptography" dependency" text), ESPContext.register and the SPI and pad-length guards in ESP.make. Then update the traceback that the module docstring and esp.rst both quote. The test_esp_unit checks are assertIn substrings, so a prefix leaves them passing.
System information
Linux, CPython 3.14.9, checkout main9d504ead5.
Activity
fix(esp): give ESP's errors the ESP: prefix and !r values (#2297) (#2366
fix(internet): the ESP read path and integrity-key warning name the p…
fix(internet): the ESP read path and integrity-key warning name the p…