Repository navigation
fix(hip): HOST_ID maker prefixes its errors [HIPv2] instead of HIPv2: [ParamNo 705] #2299
Description
Describe the bug
HIP._make_param_host_id puts the version in brackets and leaves out the parameter code: [HIPv2] invalid curve: …. Every other HIP message is written HIPv{version}: [ParamNo {code}] …, so this one does not follow the <prefix>: <lowercase description>: … {value!r} form (#2232, #2257). It occurs in the hi_curve branch and in the branch for a Data_HostIdentity passed as hi.
Reproduction (main 9d504ead5)
>>> HIP.__new__(HIP)._make_param_host_id(Parameter.HOST_ID, hi_curve='bogus', hi_pub_key=b'', version=2)
ProtocolError: [HIPv2] invalid curve: 'bogus'
Expected behavior
HIPv2: [ParamNo 705] invalid curve: 'bogus'. No test pins the current text.
System information
Linux, CPython 3.14.9, checkout main 9d504ead5.
Activity
JarryShaw commentedon Oct 26, 2026
Blocked until the #2309 fix PR merges. That fix edits the HIP REG_* parameters in
hip.py, and this one edits the same file, so it starts from the merged tree.JarryShaw commentedon Oct 27, 2026
Unblocking — #2309 merged. Open to pick up now.
fix(hip): correct 7 HIP parameter wire defects (#2271, #2275, #2276, #…
fix(hip): correct 7 HIP parameter wire defects (#2400)