Skip to content

feat(internet): implement IGMPv3 (group-record list) #2448

Closed
#2465
Closed
feat(internet): implement IGMPv3 (group-record list)#2448
#2465
Labels
enhancementIssues requesting a new capability (set by the feature request template)wipWork in flight - a covering PR is open or an agent is actively on it
Milestone
PyPCAPKit v1.6

Description

@JarryShaw
JarryShaw
opened on Oct 30, 2026

Follow-up from #2439 (IGMP v1/v2, PR #2444).

IGMPv3 (RFC 3376) adds a group-record list to the Membership Report (type 0x22) and an extended Query format with source-list filtering. #2439/#2444 deliberately scoped this out — PR #2444's dispatch raises ProtocolError for any type outside {0x11, 0x12, 0x16, 0x17}. For a v3 Report (0x22) this correctly falls back to Raw. For a v3 Query, correction (verified by cross-review): v3 reuses type 0x11 (same as v1/v2 Membership Query), so it currently decodes as a v1/v2 Query with the extra v3-only octets (S flag, QRV, QQIC, source list) kept as trailing Raw — RFC 2236 §2.5 explicitly permits this and no bytes are lost, so it is not a defect in #2444. One real gap to fix here: v3 Max Resp Codes ≥128 encode as floating point (RFC 3376 §4.1.1), which the current v1/v2 code reads as a plain integer tenths-of-a-second value — e.g. code 0x8c decodes as 14.0s when the real value is 22.4s. A v3 Query parser needs the floating-point decode for this field.

Scope: a new schema/data model for the v3 Membership Report's group-record list, the v3 Query's extended fields, and the floating-point Max Resp Code/QQIC decode. Likely shares IGMP's base rather than needing its own ICMP_Family-style split, since v3 is a strict superset dispatched by the same type bytes.

Activity

  1. JarryShaw
    added
    enhancementIssues requesting a new capability (set by the feature request template)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 30, 2026
  2. github-actions
    added this to the PyPCAPKit v1.5 milestone on Oct 30, 2026
  3. JarryShaw
    added this to PyPCAPKiton Oct 30, 2026
  4. JarryShaw
    moved this to Pending in PyPCAPKiton Oct 30, 2026
  5. JarryShaw
    added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 30, 2026
  6. JarryShaw
    moved this from Pending to WIP in PyPCAPKiton Oct 30, 2026
  7. JarryShaw
    added a commit that references this issue on Oct 30, 2026

    feat(internet): implement IGMPv3 (#2448)

    93c4c71
  8. JarryShaw
    added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 30, 2026
  9. JarryShaw
    moved this from WIP to Blocked in PyPCAPKiton Oct 30, 2026
  10. JarryShaw
    added a commit that references this issue on Oct 30, 2026

    fix(internet): refuse non-8-octet IGMP Queries as IGMPv1/v2 (#2439)

    675b590
  11. JarryShaw
    modified the milestones: PyPCAPKit v1.5, PyPCAPKit v1.6 on Oct 31, 2026

  12. 4 remaining items

  13. JarryShaw
    added 4 commits that reference this issue on Oct 31, 2026

    feat(internet): implement IGMPv3 (#2448)

    427c911

    feat(internet): implement IGMPv3 (#2448)

    6bd9733

    feat(internet): implement IGMPv3 (#2448)

    b235f4d

    fix(tests): repair fused merge text and bump census pins for IGMPv3

    949b638
  14. JarryShaw
    added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 31, 2026

  15. JarryShaw commented on Oct 31, 2026

    @JarryShaw
    JarryShaw
    on Oct 31, 2026
    OwnerAuthor

    Relabeled blocked -> wip: PR #2465 covers this issue (Closes #2448) and is now review: good-to-go, pending only the owner's merge. No comment here stated a checkable blocking condition, and blocked implies nothing is actively being worked -- that's no longer true.

  16. JarryShaw
    moved this from Blocked to WIP in PyPCAPKiton Oct 31, 2026
  17. JarryShaw
    added 4 commits that reference this issue on Oct 31, 2026

    feat(internet): implement IGMPv3 (#2448)

    802a064

    fix(tests): repair fused merge text and bump census pins for IGMPv3

    8c5dbb3

    feat(internet): implement IGMPv3 (#2448)

    c5af34e

    fix(tests): repair fused merge text and bump census pins for IGMPv3

    04626e9
  18. JarryShaw
    closed this as completedin #2465on Oct 31, 2026
  19. github-project-automation
    moved this from WIP to Done in PyPCAPKiton Oct 31, 2026
  20. JarryShaw
    added a commit that references this issue on Nov 1, 2026

    docs(internet): align IGMP alias and family docs with the id() ruling (…

    73add05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementIssues requesting a new capability (set by the feature request template)wipWork in flight - a covering PR is open or an agent is actively on it

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions