You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
UDP checksum verification and computation (one's-complement, queued with #2470/#2471) #2474
UDP checksum verification and computation (one's-complement, queued with #2470/#2471)
Summary
Part of the owner's 2026-10-30 ruling on #2470: the one's-complement checksum work for IPv4/TCP/UDP/ICMP/ICMPv6/OSPF is queued and done together rather than piecemeal, through #2471's shared pseudo-protocol class.
pcapkit.protocols.transport.udp.UDP.read() does not verify the wire checksum field; a corrupted capture parses silently.
pcapkit.protocols.transport.udp.UDP.make() leaves checksum unset/zero rather than computing the real checksum (RFC 768, over the UDP pseudo-header + datagram, with the zero-means-unused exception on IPv4).
Scope
Follows the Protocol class conventions, using #2471's pseudo-protocol class for any value from the enclosing IP layer this checksum needs. See docs/source/contributing/pep.rst, "Checksum and Integrity Verification", for the full cross-protocol plan.
Blocked on
#2471 (the shared pseudo-protocol class) landing first.
Unblocked: #2479 (IP_Pseudo) merged as a7d332147. Dispatched as a single checksum wave covering #2470, #2472, #2473, #2474 and #2475 on one branch, since these issues say they land together. It follows pep.rst's checksum section: an opt-in flag, a ProtocolWarning plus a recorded status in the ESPStatus shape, and the pseudo-header taken from IP_Pseudo. It opens as one PR once reviewed.
Activity
JarryShaw commentedon Nov 1, 2026
Unblocked: #2479 (
IP_Pseudo) merged asa7d332147. Dispatched as a single checksum wave covering #2470, #2472, #2473, #2474 and #2475 on one branch, since these issues say they land together. It follows pep.rst's checksum section: an opt-in flag, aProtocolWarningplus a recorded status in the ESPStatus shape, and the pseudo-header taken fromIP_Pseudo. It opens as one PR once reviewed.JarryShaw commentedon Nov 1, 2026
Done in #2543, which merged as the checksum wave. Its body listed this issue after one
Closes, which GitHub reads as closing only the first.