Skip to content

Reorder protocol class members to the member-order convention #2490

Open

Description

@JarryShaw

Reorder protocol class members on main to the member-order convention. Ruled by the owner: HTTP v1 is a violation; dunders (__init__, __new__, __post_init__, __index__, __length_hint__, and the rest) are Data Models; the old protocols (IPv4, TCP, UDP, ARP, Ethernet, IPv6) are the reference.

Order inside a protocol class body: properties, public methods (id, read, make, register_*), dunders (Data Models), then utilities (_read_xxx before its _make_xxx).

Landed violations (ref: audit on 545ad0ca7): application/application.py, application/httpv1.py (HTTP), application/httpv2.py, application/ospf.py, application/ssl.py, data/application/httpv2.py, internet/esp.py, internet/hip.py, internet/ipv6_route.py, internet/ipx.py, internet/mh.py, misc/pcap/frame.py, misc/pcap/header.py, misc/pcapng.py, protocol.py (ProtocolBase), schema/misc/pcapng.py, schema/schema.py, transport/sctp.py.

Open PR-only violations are fixed by each PR's own rework (#2444, #2446, #2465, #2466).

Mechanical reorder only; no behaviour change. Split by file group, one PR per group.

Activity

  1. added
    refactorRestructuring for its own sake — neither a fix nor a new capability (refactor: prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 31, 2026
  2. JarryShaw commented on Oct 31, 2026

    @JarryShaw
    OwnerAuthor

    Held: Actions queue at 78 (well above the hold line). The member-order reorder dispatches when the queue drops below 40.

  3. moved this to Pending in PyPCAPKiton Oct 31, 2026
  4. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 31, 2026
  5. moved this from Pending to WIP in PyPCAPKiton Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorRestructuring for its own sake — neither a fix nor a new capability (refactor: prefix)wipWork in flight - a covering PR is open or an agent is actively on it

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions