Skip to content

fix(application): a successful SSLv2 fallback still reports TLS's rejected header read #2525

Closed

Description

@JarryShaw

Reproduced by #2519's cross-review, on main and on #2519 alike. An SSLv2-format CLIENT-HELLO advertising 0x0300, 0x0301 or 0x0303 on TCP 443 parses as TCP:SSLv2, but TLS's rejected record-header read still reports SchemaWarning: packet length < 0 (-743, -744, -746). The TLS layer is kept, so its held warnings replay. Under an error filter it is worse: the valid hello becomes TCP:Raw with error='packet length < 0: -743'. This is the classic SSLv2-compatible ClientHello, so it is common in real captures.

Fix: hold TLS.read's TLS-record trial and discard its warnings when the SSLv2 fallback succeeds; add tests under both always and error. Paired with #2517 in one worker, since both change how TLS.read handles its records.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Nov 1, 2026
  2. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions