Repository navigation
refactor(corekit): move the Internet checksum helpers to corekit.internet_checksum #2580
Description
From the owner on #2543: pcapkit.protocols.misc.checksum.checksum belongs in foundation or corekit, under a name that says it is the Internet checksum (RFC 1071), not a generic one. It is new in 1.6.0 and unreleased, so it moves with no versionremoved.
Where it can go. The module imports pcapkit.protocols.protocol._rebuilding, and IPv4/IPv6/TCP/UDP/ICMP/OSPF call it from read(). Since #2528, protocol read code imports nothing from pcapkit.foundation, so foundation would invert the layers. utilities-or-corekit.rst puts what protocols are made of in corekit.
Decision needed:
- (a) Split. The protocol-independent part becomes
pcapkit.corekit.internet_checksum:ChecksumStatus, the RFC 1071 sum (internet_checksum,compute_checksum,partial_checksum),verify_checksum,fragment_payload, with_rebuildingmoving there fromprotocols.protocol. The IP-specificpseudo_headerandverify_upperstay next toIP_Pseudoinprotocols.misc.checksum.
(b) Move the whole module topcapkit.foundation.internet_checksum, and accept protocols importing foundation. - The
ChecksumWarningclass stays inpcapkit.utilities.warnings.
Recommendation: 1(a). It keeps protocol read free of foundation imports, and corekit takes only what has no protocol dependency.
Activity
JarryShaw commentedon Nov 1, 2026
1(a), but name probably should be corekit.checkum.internet, save room for future other checksum calculations that will live aside in the corekit.checksum module.
JarryShaw commentedon Nov 1, 2026
Owner chose 1(a), with a different name, paraphrased:
pcapkit.corekit.checksumbecomes a package, so other checksum families can sit beside it later, and the Internet checksum goes inpcapkit.corekit.checksum.internet.ChecksumStatus, the RFC 1071 sum,verify_checksumandfragment_payload, with_rebuildingmoving fromprotocols.protocol.IP_Pseudo: the IP-specificpseudo_headerandverify_upper.versionremoved: the module is unreleased.Dispatched.
refactor(corekit): move the Internet checksum into corekit.checksum.i…