Skip to content

test: the dispatch generator has no family for LinuxSLL's ARPHRD registry #2592

Open

Description

@JarryShaw

LinuxSLL.__proto__, the ARPHRD-keyed registry from #2510/#2527, has entries for FRAD, IPGRE, IP6GRE, IEEE80211_RADIOTAP and NETLINK, but no Family in examples/generators/dispatch.py. The FRAD probe that #2560 adds reaches LinuxSLL's FRAD entry only indirectly, and nothing generates the others. test-coverage.rst's protocol row asks for a PINNED_TARGETS entry per __proto__ registration, but it does not say that a protocol with a registry of its own (FRAD, Loopback, LinuxSLL) also needs a Family. That gap is how #2560 happened.

Fix: add a linux_sll family covering every LinuxSLL.__proto__ entry, with PINNED_TARGETS, and bump the count guard in test_cases_cover_every_table_named_in_the_issue. Add the missing clause to test-coverage.rst's protocol row.

Blocked: #2560's branch, #2575 (radiotap) and #2489 (DCCP) all append to dispatch.py's FAMILIES/PINNED_TARGETS and to that count guard. This issue unblocks when their PRs merge (gh pr view <n> --json state -q .state prints MERGED).

Activity

  1. added
    testPull requests that add or correct tests (test: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Nov 1, 2026
  2. moved this to Blocked in PyPCAPKiton Nov 1, 2026
  3. added this to the PyPCAPKit v1.6 milestone on Nov 2, 2026
  4. JarryShaw commented on Nov 2, 2026

    @JarryShaw
    OwnerAuthor

    #2560, #2575 and #2489 have merged. #2615 is restructuring examples/generators/dispatch.py and the dispatch-case count guard so that concurrent additions stop conflicting. Still blocked: this unblocks when #2615's PR merges, after which the linux_sll family becomes a one-entry addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blockedDeferred pending another issue or decision; see the last comment for what unblocks ittestPull requests that add or correct tests (test: subject prefix)

    Projects

    • Status
      Blocked

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions