Repository navigation
docs: prose sweep after the defect wave (schema-data) (#1103) - #1179
Merged
Merged
Conversation
MesgIDOption.seconds is an RFC 1305 NTP second count, which post_process rebases by 2,208,988,800 s; its comment named the 1970 UNIX epoch. Part of #1103
Owner
Author
|
Cross-review verdict on
|
Contributor
|
Coverage: 88.89% (unit tier, Python 3.14,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort) — not run; comment-only change, AST guard belowmake testpasses, and a test case covers the change — per-module runs below; prose onlyWhat is the purpose of your pull request?
docs— documentation onlyDescription of your pull request and other information
Part of #1103. Slice
schema-data: the wave's prose inpcapkit/protocols/schema/,pcapkit/protocols/data/,corekit/fields/misc.pyandcorekit/protochain.py(15 files).One fix:
MesgIDOption.secondsinschema/internet/mh.pysaid "seconds since January 1st, 1970". It is an RFC 1305 NTP count from 1900, which is whypost_process(edited by the wave) subtracts2_208_988_800.NTPTimestamp.secondsin the protocol module already says 1900.Every other wave-added comment was checked against the code and left alone, including the
SchemaField.unpackNOTE (checked againstprepare), the Quick-Start width NOTE (8 octets in the schema, RFC 4782 §3.2) and theContextRequestOptionnote (a probe confirmed theSchemaWarningand zero padding).pcapkit/protocols/schema/internet/mh.pyTests:
test_mh_unit.py52 passed;test_mh_mesg_id_fraction_unit.py4 passed;tests/project389 passed, 1 skipped.