Repository navigation
fix(hip): three BitField namespaces leave reserved bits unnamed, so they rebuild as zero - #1419
Merged
Merged
Conversation
…hey rebuild as zero Name a `reserved` sub-field at each site (#654 policy) and carry it through the reader, data model and make() (default 0): - HIP.ver (4, 3): Data_HIP.reserved, make(version_reserved=) - RouteDstParameter.flags / RouteViaParameter.flags (2, 14): Data Flags.reserved, _make_param_route_*(flags_reserved=) test_hip_unit.py built the old namespace dicts and Flags without the new field; updated to supply it.
Owner
Author
|
Verdict: GOOD TO GO at
|
Contributor
|
Coverage: 89.43% (unit tier, Python 3.14,
Per-file detail: the |
JarryShaw
added a commit
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort) — not runmake testpasses, and a test case covers the change — the 11test_hip_*modules, 7 relatedtests/protocolsmodules,tests/project, and theprotocols/internetleg (570 tests, OK)Changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657
fix— corrects a defectCloses #1417
Refs #1288
Names
reservedatHIP.ver(4, 3) and atRouteDstParameter.flags/RouteViaParameter.flags(2, 14), per #654, carried through the reader, the data model andmake()(default 0). The newmake()keywords areversion_reservedandflags_reserved.Rebuilt through
HIP.from_data(p.info).data:ver2f→21before,2fafter;ROUTE_DST/ROUTE_VIAflagsffff→c000before,ffffafter.Breaking:
data.internet.hip.HIPanddata.internet.hip.Flagsgain a requiredreservedfield.test_hip_unit.pybuilt the old namespace dicts andFlagswithout it, so I updated it.New
tests/protocols/internet/test_hip_reserved_bits_unit.py: 4 tests, 19 subtests, all passing; all 4 tests fail with the fix reverted.Rebase note: #1416 has not merged. When rebasing over it, remove the 3 HIP entries from
KNOWN_GAPSintests/protocols/schema/test_bitfield_coverage_unit.py.