Repository navigation
fix(ipv6): dissect a jumbogram's payload up to its Jumbo Payload Length (#1434) - #1440
Merged
Merged
Conversation
…th (#1434) - An IPv6 jumbogram (Payload Length 0 with a Hop-by-Hop Jumbo Payload option, RFC 2675) read no payload, so its next layer was NoPayload and the whole jumbo payload landed in info.trailer. The schema now splits payload and trailer at the Jumbo Payload Length, and the payload is dissected as the next header; only octets beyond it are trailer. - The option is honoured only in a Hop-by-Hop header immediately after the IPv6 header. Beside a non-zero Payload Length it is an RFC 2675 error: the Payload Length still governs, and a ProtocolWarning is emitted. - make() writes Payload Length 0 when the payload exceeds 65,535 octets. Rebuilds stay byte-exact; tests in test_ipv6_jumbogram_unit.py.
Owner
Author
|
Verdict: GOOD TO GO at
Nits, no change needed:
|
Contributor
|
Coverage: 89.49% (unit tier, Python 3.14,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for similar pull requests
Followed the coding style — isort/pylint/mypy run on the 3 source files; every pylint/mypy message is on a line this PR does not touch
make testpasses, and a test case covers the change — new module (9 passed), IPv6/HOPOPT modules,run_unittest_leg.py protocols/internet(589 OK),tests/project(404 passed)Changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657
fix— corrects a defectCloses #1434
A jumbogram (Payload Length 0, Hop-by-Hop Jumbo Payload option) read no payload. The schema now splits
payload/trailerat the Jumbo Payload Length, so the payload is dissected and only octets past it aretrailer. The option counts only in a Hop-by-Hop header right after the IPv6 header (RFC 8200 §4.1). Beside a non-zero Payload Length (an RFC 2675 error) the Payload Length still governs, as captured, with aProtocolWarning.make()writes Payload Length 0 when the payload exceeds 65,535 octets. Noinfokey is added or removed;raw_lennow counts from the Jumbo length.mainnext / trailerraw_len92)Every case rebuilds byte-exact before and after. 7 of the 9 new tests fail without the fix; the other 2 pin unchanged cases. Per-frame
infodigests of the 1616 frames inexamples/captures/matchmain.