Repository navigation
ci: queue the ordering cells after the unit legs, run Engines 3.15 on main only, drop Engines (DPKT) (#1538) - #1551
Merged
Merged
Conversation
… main only, drop Engines (DPKT) (#1538) - unittest-ordering: needs: [test], with !cancelled() leading its if:, so its 11 cells queue behind the push run's own legs instead of ahead of them, still run when test fails, and still fail the push run (#1052 item H unchanged). - engine-tests: the 3.15 step skips on pull requests; same name, still continue-on-error. Narrows #845's ruling to main pushes. - engine-tests: no DPKT cell; its only path, test_dpkt_unit.py, already runs in test with DPKT on 3.10-3.14. - Tests pin all three; tier-guard doctoring moves off the retired DPKT arms; workflows.rst documents the cuts. Refs #1538
Owner
Author
|
Verdict: GOOD TO GO at
For the owner, P4(a) measured: this comes from 60 push runs and 127 PR runs, replayed against the 20-slot pool.
Not blocking:
|
Contributor
|
Coverage: 90.02% (unit tier, Python 3.14,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription of your pull request and other information
Refs #1538: P4 option (a), P6 and P8. #1538 stays open for P1, P2 and P7.
unittest-orderinggetsneeds: [test]. Itsif:is the old one with!cancelled() &&in front, so the cells still run whentestfails or is skipped, and a red cell still fails the push run that Pages, Conda, Vendor and Release wait on. No concurrency group is added (ci: stop dropping a commit's validation when the next one lands #394).Run the 3.15 cell (experimental, non-blocking)getsif: ${{ github.event_name != 'pull_request' }}. The name andcontinue-on-error: trueare unchanged. This narrows ci: engines not exercised across their claimed Python ranges — PyShark has no real-capture coverage, PyPCAPFile dark on 3 of 5 legs #845's ruling to main pushes.DPKTis removed fromengine-tests' matrix and from both case arms. The premise holds: the cell's only TEST_PATHS entry wastests/toolkit/test_dpkt_unit.py.testinstalls.[test,DPKT,crypto,NGAP]on 3.10–3.14 and runs that file, since none of its--ignores match it. The DPKT job failed in 0 of the 120 cached runs from Oct 5–9. What is lost: that file run in a venv with only.[test]and DPKT, and run on 3.15.required-checks'needs:is unchanged, and no other workflowneeds:these jobs. No permission is added. The net line change abovechangelog:is zero, so everyunit-tests.yml:Ncitation still resolves.Saving. Figures are estimates unless measured.
Pythonlegs, and those legs queued for 13–19 min.Tests. Three new
TestJobGatingcases each fail on main's workflow. The tier-guard doctoring now edits the Scapy/PyShark arms instead of the retired DPKT ones. Results:tests/project469 passed,tests/test_tier_guard.py109 passed.