Repository navigation
test(project): judge the tree against an isort whose verdict the test was written for (#1696) - #1698
Merged
Merged
Conversation
… was written for (#1696) - isort is unpinned, so the 3.8 and 3.9 KTLO legs install 5.13.2 and 6.1.0, which call five files red that 9.x calls clean. The isort-clean test now skips when the installed isort predates 9.0.1, with a reason naming the floor, and runs as before on 9.0.1 and newer. - The floor is bisected, not invented: the verdict moved at 9.0.0b1, and 9.0.0b5 and 9.0.0 cannot run under `python -m isort`. The per-release result is recorded next to ISORT_FLOOR. Skips on 3.8 (isort 5.13.2) and 3.9 (6.1.0); 1 passed, 4 subtests on 3.10 (9.0.2) and 3.14 (9.0.1), the same count as on main.
Owner
Author
|
Verdict: GOOD TO GO at |
Contributor
|
Coverage: 89.47% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Not run in full; only the narrow runs below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription of your pull request and other information
isortis unpinned, so the 3.8 leg installs 5.13.2 and the 3.9 leg 6.1.0. Both call five files red that 9.x calls clean.test_check_only_is_clean_on_every_makefile_linenow skips when the installed isort is older than 9.0.1, and the skip reason names that floor. On 9.0.1 and later it runs unchanged, so a newer isort whose verdict moves still turns it red, aspyproject.tomlintends. Onlytests/project/test_isort_clean.pychanges.The floor comes from a bisection. Each release got a fresh venv on CPython 3.10.21 and ran all four
isort:recipe lines throughpython -m isort --check-only, which is how the test runs them:dpkt.pyonlyNo code object available for isort.__main__(the console script reports clean)The same table is in the comment on
ISORT_FLOOR. The version comes fromimportlib.metadata, so the test never imports isort. The new decorator is askipIf, so the class-levelHAS_ISORTgate thattests/test_tier_guard.pyaudits stays as it was. Results are identical before and after rebasing onto8035434a2, which changeddpkt.pyandpyshark.py.On
origin/mainthe test fails on 3.8.20 and 3.9.25. With this change it skips on both, and on 3.10.21 (isort 9.0.2) and 3.14.8 (9.0.1) it gives1 passed, 4 subtests passed, the same count as on main. An unsortedtemp/sort.pystill turns it red on 3.14.tests/test_tier_guard.pypasses on 3.14 (110 passed).Closes #1696