Skip to content

test: spell test_base_class_contract's suffix strip so Python 3.8 runs it (#1699) #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarryShaw merged 1 commit into from
Oct 14, 2026
Merged

test: spell test_base_class_contract's suffix strip so Python 3.8 runs it (#1699) #1700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/test_base_class_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ class itself*, so identity is what is asserted, not absence: the name
may exist, it just may not be the base.

"""
pending = tuple(rel.removesuffix('.py').replace('/', '.')
# Not ``str.removesuffix``: that is Python 3.9+, and the 3.8 leg runs
# this line as soon as the dict gains an entry. C.f. #1699.
pending = tuple((rel[:-len('.py')] if rel.endswith('.py') else rel).replace('/', '.')
for rel in PENDING_ALIAS_PATHS)

offenders = []
Expand Down
Loading