Repository navigation
docs(extraction): name only PyShark and PyPCAPFile for the PCAP trace warning (#1719) - #1720
Merged
Merged
Conversation
… warning (#1719) - Extractor.__init__ Warns: the PCAP-trace bullet still named DPKT and Scapy, which left the trace_format guard in #1507; it now names only PyShark and PyPCAPFile, matching the guard - the PCAP-output bullet (DPKT, Scapy, PyShark, PyPCAP, pcap-ct, PyPCAPFile) was checked against its guard and is accurate; unchanged - tests/foundation/test_extraction.py: two tests parse each bullet's engine list and compare it with the engines its guard actually warns for, so the docstring and the guard tuples cannot drift apart again Closes #1719 tests/foundation/test_extraction.py: 24 passed; the trace-bullet test fails against the unfixed docstring ('dpkt', 'scapy' extra).
JarryShaw
added
docs
Owner
Author
|
Verdict: GOOD TO GO at
|
Contributor
|
Coverage: 89.47% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription of your pull request and other information
Closes #1719.
Extractor.__init__'sWarns:bullet for PCAP trace output named DPKT and Scapy. The guard atpcapkit/foundation/extraction.py:1315stopped warning for those two in design: late duplicate IP fragments, and dpkt/scapy trace_format=pcap fallback #1507. The bullet now names only PyShark and PyPCAPFile.:1192and is unchanged.tests/foundation/test_extraction.pyrun the constructor once per registered engine, collect the engines each guard warns for, and compare that set with the engines the bullet names.'dpkt'and'scapy'extra. Removingpcap-ctfrom the second bullet makes the other test fail too.pytest tests/foundation/test_extraction.py: 24 passed.