[JarryShaw]

Please follow the guide below

• You will be asked some questions, please read them carefully and answer honestly

• Put an x into all the boxes [ ] relevant to your pull request (like that [x])

• Use Preview tab to see how your pull request will actually look like

• Searched for similar pull requests

• Followed the coding style (make pylint, make mypy, make isort)

• make test passes, and a test case covers the change. Narrow runs only, listed below.

• Added a changelog entry under docs/source/changelog/ and regenerated CHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

Tick the commit type your subject line carries.

• fix — corrects a defect
• feat — adds a feature
• perf — changes performance, not behaviour
• refactor — changes neither behaviour nor performance
• test — tests only
• docs — documentation only
• ci — workflows or build tooling
• release — bumps the version or rolls up a distribution
• chore — anything else

---

Description

Part of #1103, the whole-repository prose sweep, for the application slice. It follows the #719 rules: prose only, accuracy first, no churn and no timed context.

Version directives (1.5.0), in module docstrings and on the pages:

• versionchanged for the rebuild and construction-keyword changes on
  Application, FTP, HTTP/1.*, HTTP/2, PCAP, PCAP-NG and the base
• versionadded/versionremoved for the OSPF and RARP move out of
  protocols.link and the CryptographicAuthentication rename
• versionchanged on schema_final (@Final enforced) and Option's ns=

Accuracy:

• pack() builds from kwargs alone and replaces header; the
  _check_construction_keywords kwargs cover from_data too
• "contains X only" fixed in protocol.py, httpv1 and pcapng
• Engine's keyword is engine=; register() checks ProtocolBase; the
  beholder and Schema.get_payload refs name the defining modules
• TLSKeyLabel directive cites issue refactor(vendor,pcapng): generate TLSKeyLabel from RFC 9850's IANA registry instead of maintaining it by hand #886, not PR refactor(vendor,pcapng): generate TLSKeyLabel from the RFC 9850 IANA registry #890
• timed wording ("currently", "no longer", "as before") removed

Render: literals moved out of bold, a Note split by the injected rtype
moved, a role broken over two lines joined, a duplicate automethod cut.

Checks:

• An AST guard holds on every changed .py file.
• tests/project gives 930 passed and 1 skipped, and every test that reads the edited paths passes.
• A merged Sphinx build of all nine slices adds no new warnings.
• A Sonnet cross-review sent this back once. After the fix round, a re-check returned GOOD TO GO.

Not covered here; a round-2 PR follows: the rest of httpv2.py, the short pcapng and pcapng-schema docstrings, and pcapkit/protocols/data/**, which no slice covered.

Refs #1103

[JarryShaw]

Verdict: GOOD TO GO at d865570d7. A Sonnet cross-review checked it (author: Opus), after one fix round.

• First review, two blocking findings:
  • the pcapng option-overrun sentence said such an option is refused;
  • NGAP carried versionchanged although the class is new in 1.5.0.
• Re-check: both are fixed, and the overrun behaviour was measured on the head and on v1.4.1.post2. An overrunning option now leaves its area kept as captured in options_raw, with a ProtocolWarning; 1.4.x read zeros.
• AST guard: all 18 .py files are identical once docstrings are blanked.
• Tests: tests/project gives 930 passed.

[JarryShaw]

Verdict: NEEDS CHANGES at d865570d7. This supersedes the earlier good-to-go. The register Raises: clauses in pcapkit/protocols/protocol.py were changed to say "not a ProtocolBase subclass". #1016 settled that the public registration door names the public class, and #1028 deliberately kept these clauses on Protocol; ProtocolBase is documented as internal-only. Those lines go back to Protocol. The same rewording in the #1103 round-2 commits is being reverted in the same pass.

[JarryShaw]

Correction: this PR had already merged when I posted the note above, so nothing changes here. The revert of the ProtocolBase wording in protocol.py's Raises: clauses goes into the #1103 round-2 application PR instead.