Repository navigation
docs(contributing): spell out KTLO where it is defined and link its earlier mentions (#1950) - #1951
Merged
Merged
Conversation
…arlier mentions (#1950) - workflows.rst: expand KTLO as "keep the lights on" in the tier paragraph and label it ktlo-tier; link the page's first mention, which precedes it. - releasing.rst: link the page's first KTLO mention to that label. - tests: pin the expansion under the label, and that each page's first prose mention links there or follows the definition; Markdown spells it out. Closes #1950
JarryShaw
added
docs
Owner
Author
|
GOOD TO GO at |
JarryShaw
added
review: good-to-go
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription of your pull request and other information
Spells out KTLO (keep the lights on) where
workflows.rstdefines the tier, labels itktlo-tier, and links each contributor page's first mention to it (workflows.rst,releasing.rst). Job names such as(KTLO)stay literal, and no Markdown file uses the acronym.tests/project/test_docs_ktlo_defined_1950_unit.pypins the expansion under the label and each page's first-mention link, and fails onmain. The docs build has no warnings.Closes #1950